Update openssl to 3.3.2 under cloud-hypervisor-cvm in order to address CVE-2024-6119 #10475
+35
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PawelWMS
reviewed
Sep 17, 2024
PawelWMS
reviewed
Sep 17, 2024
PawelWMS
reviewed
Sep 17, 2024
PawelWMS
reviewed
Sep 17, 2024
SPECS/cloud-hypervisor-cvm/upgrade-openssl-to-3.3.2-to-address-CVE-2024-6119.patch
Show resolved
Hide resolved
jiria
force-pushed
the
jiria/CVE-2024-6119-3.0
branch
from
ae60794
to
754faf8
Compare
jiria
force-pushed
the
jiria/CVE-2024-6119-3.0
branch
from
754faf8
to
542f11f
Compare
PawelWMS
approved these changes
Sep 17, 2024
jslobodzian
reviewed
Sep 18, 2024
| # cd %%{name}-%%{version} | ||
| # cargo update -p openssl-src --precise 300.3.2+3.3.2 | ||
| # diff -u ../cloud-hypervisor-msft-v38.0.72.2.backup/Cargo.lock Cargo.lock > ../upgrade-openssl-to-3.3.2-to-address-CVE-2024-6119.patch | ||
| Patch0: upgrade-openssl-to-3.3.2-to-address-CVE-2024-6119.patch |
There was a problem hiding this comment.
In theory we should be able to introduce openssh-devel and the rust build should use the system version of openssh and break the dependency on openssl. I think and I think that might be a better solution.
There was a problem hiding this comment.
Is that something that you want to do as part of high sev CVE as opposed to merging as is and addressing separately?
There was a problem hiding this comment.
I am ok taking it this way, but nobody will follow up on that until the next CVE issue. If my suggestion is correct, then it will be essentially fix this issue permanently...and I think that would be a better solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update openssl to 3.3.2 under cloud-hypervisor-cvm in order to address CVE-2024-6119
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
This PR updates
openssldependency ofcloud-hypervisor-cvmto version3.3.2, as that is the version that contains a patch for CVE-2024-6119. The patch has been included into the vendored archive and is also part of this change.Change Log
Does this affect the toolchain?
NO
Links to CVEs
Test Methodology