Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Use Toolchain RPMS when building Golden Container #10474

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

rikenm1
Copy link
Contributor

@rikenm1 rikenm1 commented Sep 17, 2024

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?
Use Toolchain RPMS while building GC containers

Change Log
  • Change: Use Toolchain RPMS while building GC containers
Does this affect the toolchain?

YES/NO
NO

Test Methodology

@rikenm1 rikenm1 added the 3.0-dev PRs Destined for AzureLinux 3.0 label Sep 17, 2024
@rikenm1 rikenm1 marked this pull request as ready for review September 17, 2024 23:38
@rikenm1 rikenm1 requested a review from a team as a code owner September 17, 2024 23:38
@rikenm1 rikenm1 merged commit b8bc858 into 3.0-dev Sep 19, 2024
12 checks passed
@rikenm1 rikenm1 deleted the rmaharjan/3.0-gc-toolchain-rpm branch September 19, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants