Adding CD as commented section #240
Conversation
| inputs: | ||
| platform: '$(buildPlatform)' | ||
| configuration: '$(buildConfiguration)' | ||
| #- stage: Deploy |
There was a problem hiding this comment.
Instead of commenting out the entire section, we should introduce stage condition with a variable initialized such that it will skip the stage.
There was a problem hiding this comment.
The problem with this is that it will impact the user experience. It will show two stages in all runs in the landing page and in the summary. The second stage will always show as skipped. There are some optimizations in the UI for a single stage pipeline. Those will be lost. I would like to start here and see how many people uncomment this section and grow up from here.
There was a problem hiding this comment.
This is a syntax flaw in my opinion. Something like insertCondition: would be a very welcome feature. Sure, it can partly be solved using expressions, but it's clunky, has a goofy syntax, poor VSCode support and can't be used with variables not available at template compile time.
| # jobs: | ||
| # - deployment: Deploy | ||
| # displayName: Deploy | ||
| # environment: '$(EnvironmentName)' |
There was a problem hiding this comment.
EnvironmentName variable is not initialized. We should evaluate using different defaults.For example reponame-dev and/or appname-dev
| # displayName: Deploy | ||
| # environment: '$(EnvironmentName)' | ||
| # pool: | ||
| # vmImage: $(vmImageName) |
There was a problem hiding this comment.
Build stage is using "windows-latest", we should have a variable that can be used across here?
| @@ -6,29 +6,51 @@ | |||
| trigger: | |||
| - master | |||
|
|
|||
| pool: | |||
| vmImage: 'windows-latest' | |||
| stages: | |||
There was a problem hiding this comment.
It is unclear to me what this template is supposed to do. Ideally it should be build and deploy .Net core app to Azure Web App or Web App Linux or equivalent.
There was a problem hiding this comment.
There are so many options to deploy a .net core app. It looks like the intent of this template is to provide enough of a boiler plate so that one can later add the script/task more easily through the editor. I agree that this is a good step.
| # runOnce: | ||
| # deploy: | ||
| # steps: | ||
| # - script: echo Replace this step with your Deployment configuration |
There was a problem hiding this comment.
This should be WebApp deploy step with subscription, appname as inputs in the wizard. Check if UI panel can be bypassed if the stage is disabled
I took a shot at adding CD section as a commented block in CI template so that customers can gradually grow into CD.