Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Node runner deprecation check #4969

Merged
merged 6 commits into from
Aug 30, 2024

Conversation

DenisNikulin5
Copy link
Contributor

@DenisNikulin5 DenisNikulin5 commented Aug 29, 2024

In this PR I fixed the bug when an exception raises during task downloading process if the task doesn't have the main execution step (only pre- or post-execution ones)

For example, it happened with the DownloadSecureFile task - #4962

Related WI: AB#2210002
Testing: Manual

@DenisNikulin5 DenisNikulin5 requested review from a team as code owners August 29, 2024 09:21
@DenisNikulin5
Copy link
Contributor Author

Added handling for all stages (pre-, post-, execution) since some tasks can have different handlers for every stage
Thanks @DmitriiBobreshev for help!

@DenisNikulin5 DenisNikulin5 merged commit 8814d0d into master Aug 30, 2024
12 checks passed
@DenisNikulin5 DenisNikulin5 deleted the users/v-dennikulin/fix-runner-deprecation-check branch August 30, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants