Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize directory separators in target path #4820

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KirillOsenkov
Copy link
Member

Ensure the slashes are normalized, it's possible that the subpath inside the task is using / and the TaskDirectory is using \ on Windows.

@KirillOsenkov KirillOsenkov requested review from a team as code owners May 29, 2024 01:16
@KirillOsenkov
Copy link
Member Author

We are blocked by this, our task includes dist/index.js with a forward slash, and this agent fails:

image

@KirillOsenkov
Copy link
Member Author

I noticed no VSTS tasks put their index.js in a subfolder, so we edited our task to put index.js directly into the root and that got us unblocked. While this bug is still valid, and the fix still seems good, we are no longer blocked by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants