Only pad initializer types for parameters without annotations and contextual signatures #59975

Andarist · 2024-09-15T21:16:13Z

jakebailey · 2024-09-16T20:07:52Z

typescript-bot · 2024-09-16T20:07:55Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-16T20:44:57Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-16T20:52:43Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,447k (± 0.02%)}	_{193,038k (± 0.80%)}	_~	_192,392k	_196,196k	_{p=0.298 n=6}
_{Parse Time}	_{1.30s (± 1.34%)}	_{1.30s (± 1.02%)}	_~	_1.29s	_1.32s	_{p=0.454 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.57s (± 0.57%)}	_{9.57s (± 0.36%)}	_~	_9.52s	_9.61s	_{p=0.936 n=6}
_{Emit Time}	_{2.73s (± 0.93%)}	_{2.72s (± 0.83%)}	_~	_2.68s	_2.74s	_{p=0.291 n=6}
_{Total Time}	_{14.32s (± 0.37%)}	_{14.29s (± 0.37%)}	_~	_14.19s	_14.34s	_{p=0.744 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,739k (± 0.00%)}	_{1,222,741k (± 0.00%)}	_~	_1,222,694k	_1,222,786k	_{p=0.936 n=6}
_{Parse Time}	_{6.65s (± 0.49%)}	_{6.69s (± 0.61%)}	_~	_6.64s	_6.76s	_{p=0.091 n=6}
_{Bind Time}	_{1.86s (± 0.48%)}	_{1.86s (± 0.40%)}	_~	_1.85s	_1.87s	_{p=0.798 n=6}
_{Check Time}	_{31.13s (± 0.25%)}	_{31.21s (± 0.37%)}	_~	_31.02s	_31.35s	_{p=0.199 n=6}
_{Emit Time}	_{15.07s (± 0.65%)}	_{15.05s (± 0.39%)}	_~	_14.98s	_15.12s	_{p=0.873 n=6}
_{Total Time}	_{54.71s (± 0.29%)}	_{54.81s (± 0.31%)}	_~	_54.61s	_55.10s	_{p=0.630 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,520,527	_2,520,527	_~	_~	_~	_{p=1.000 n=6}
_Types	_935,974	_935,974	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,350,349k (± 0.00%)}	_{2,350,394k (± 0.00%)}	_{+44k (+ 0.00%)}	_2,350,365k	_2,350,418k	_{p=0.037 n=6}
_{Parse Time}	_{9.27s (± 0.33%)}	_{9.28s (± 0.35%)}	_~	_9.26s	_9.33s	_{p=0.571 n=6}
_{Bind Time}	_{2.14s (± 0.57%)}	_{2.14s (± 0.69%)}	_~	_2.13s	_2.16s	_{p=0.391 n=6}
_{Check Time}	_{72.96s (± 0.52%)}	_{73.34s (± 0.52%)}	_~	_72.62s	_73.77s	_{p=0.173 n=6}
_{Emit Time}	_{0.27s (± 2.98%)}	_{0.28s (± 2.70%)}	_~	_0.27s	_0.29s	_{p=0.383 n=6}
_{Total Time}	_{84.64s (± 0.43%)}	_{85.05s (± 0.43%)}	_~	_84.35s	_85.44s	_{p=0.149 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,245,953	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_264,212	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,398,376k (± 0.03%)}	_{2,397,621k (± 0.01%)}	_{-754k (- 0.03%)}	_2,397,327k	_2,397,900k	_{p=0.045 n=6}
_{Parse Time}	_{5.09s (± 0.64%)}	_{5.11s (± 0.86%)}	_~	_5.03s	_5.15s	_{p=0.378 n=6}
_{Bind Time}	_{1.92s (± 0.33%)}	_{1.92s (± 0.79%)}	_~	_1.90s	_1.94s	_{p=0.391 n=6}
_{Check Time}	_{34.74s (± 0.22%)}	_{34.70s (± 0.54%)}	_~	_34.51s	_34.97s	_{p=0.873 n=6}
_{Emit Time}	_{3.03s (± 4.52%)}	_{3.03s (± 2.92%)}	_~	_2.97s	_3.21s	_{p=0.872 n=6}
_{Total Time}	_{44.79s (± 0.36%)}	_{44.77s (± 0.46%)}	_~	_44.58s	_45.09s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,245,953	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,213	_264,212	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,471,829k (± 0.03%)}	_{2,497,709k (± 2.54%)}	_~	_2,471,133k	_2,627,420k	_{p=0.689 n=6}
_{Parse Time}	_{6.35s (± 0.76%)}	_{6.34s (± 0.66%)}	_~	_6.30s	_6.41s	_{p=0.689 n=6}
_{Bind Time}	_{2.05s (± 0.62%)}	_{2.05s (± 0.65%)}	_~	_2.03s	_2.07s	_{p=0.935 n=6}
_{Check Time}	_{41.34s (± 0.75%)}	_{41.48s (± 0.67%)}	_~	_41.25s	_41.96s	_{p=0.261 n=6}
_{Emit Time}	_{3.69s (± 3.14%)}	_{3.69s (± 3.74%)}	_~	_3.55s	_3.88s	_{p=0.936 n=6}
_{Total Time}	_{53.46s (± 0.70%)}	_{53.57s (± 0.42%)}	_~	_53.27s	_53.95s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,885	_259,886	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,140	_106,139	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{435,604k (± 0.01%)}	_{435,589k (± 0.01%)}	_~	_435,507k	_435,656k	_{p=0.689 n=6}
_{Parse Time}	_{3.42s (± 0.67%)}	_{3.43s (± 0.50%)}	_~	_3.41s	_3.45s	_{p=0.415 n=6}
_{Bind Time}	_{1.28s (± 1.35%)}	_{1.30s (± 0.76%)}	_{+0.02s (+ 1.56%)}	_1.28s	_1.31s	_{p=0.037 n=6}
_{Check Time}	_{18.14s (± 0.19%)}	_{18.17s (± 0.47%)}	_~	_18.04s	_18.24s	_{p=0.421 n=6}
_{Emit Time}	_{1.50s (± 1.72%)}	_{1.53s (± 1.62%)}	_~	_1.50s	_1.56s	_{p=0.126 n=6}
_{Total Time}	_{24.34s (± 0.12%)}	_{24.43s (± 0.29%)}	_{+0.09s (+ 0.37%)}	_24.31s	_24.50s	_{p=0.045 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,261k (± 0.02%)}	_{370,258k (± 0.01%)}	_~	_370,203k	_370,316k	_{p=0.936 n=6}
_{Parse Time}	_{2.76s (± 0.85%)}	_{2.77s (± 0.99%)}	_~	_2.72s	_2.80s	_{p=1.000 n=6}
_{Bind Time}	_{1.57s (± 0.66%)}	_{1.57s (± 0.77%)}	_~	_1.56s	_1.59s	_{p=0.735 n=6}
_{Check Time}	_{15.74s (± 0.18%)}	_{15.77s (± 0.28%)}	_~	_15.71s	_15.83s	_{p=0.259 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.08s (± 0.23%)}	_{20.11s (± 0.24%)}	_~	_20.05s	_20.17s	_{p=0.470 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,067,616	_3,067,616	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,059,253	_1,059,253	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,173,074k (± 0.00%)}	_{3,173,005k (± 0.00%)}	_~	_3,172,962k	_3,173,069k	_{p=0.066 n=6}
_{Parse Time}	_{13.94s (± 0.29%)}	_{13.95s (± 0.26%)}	_~	_13.92s	_14.02s	_{p=0.747 n=6}
_{Bind Time}	_{4.38s (± 1.98%)}	_{4.38s (± 1.80%)}	_~	_4.34s	_4.54s	_{p=1.000 n=6}
_{Check Time}	_{81.62s (± 0.29%)}	_{81.40s (± 0.32%)}	_~	_80.99s	_81.63s	_{p=0.173 n=6}
_{Emit Time}	_{22.22s (± 0.50%)}	_{22.17s (± 0.46%)}	_~	_22.07s	_22.31s	_{p=0.423 n=6}
_{Total Time}	_{122.16s (± 0.23%)}	_{121.90s (± 0.28%)}	_~	_121.35s	_122.21s	_{p=0.092 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,156	_277,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,946	_112,946	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,997k (± 0.03%)}	_{426,880k (± 0.03%)}	_~	_426,728k	_427,022k	_{p=0.128 n=6}
_{Parse Time}	_{4.90s (± 0.61%)}	_{4.90s (± 0.36%)}	_~	_4.88s	_4.93s	_{p=0.570 n=6}
_{Bind Time}	_{2.15s (± 0.81%)}	_{2.13s (± 0.64%)}	_~	_2.11s	_2.15s	_{p=0.192 n=6}
_{Check Time}	_{21.81s (± 0.61%)}	_{21.71s (± 0.23%)}	_~	_21.63s	_21.76s	_{p=0.173 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.85s (± 0.46%)}	_{28.74s (± 0.21%)}	_~	_28.67s	_28.81s	_{p=0.173 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_531,582	_531,582	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,676	_181,676	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,742k (± 0.03%)}	_{463,699k (± 0.01%)}	_~	_463,620k	_463,792k	_{p=0.810 n=6}
_{Parse Time}	_{3.13s (± 0.60%)}	_{3.11s (± 0.84%)}	_~	_3.08s	_3.15s	_{p=0.295 n=6}
_{Bind Time}	_{1.11s (± 0.46%)}	_{1.11s (± 0.37%)}	_~	_1.11s	_1.12s	_{p=0.595 n=6}
_{Check Time}	_{18.20s (± 0.22%)}	_{18.21s (± 0.40%)}	_~	_18.08s	_18.27s	_{p=0.335 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.43s (± 0.17%)}	_{22.44s (± 0.23%)}	_~	_22.35s	_22.50s	_{p=0.809 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-16T21:00:08Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59975/merge:

Everything looks good!

typescript-bot · 2024-09-16T22:05:00Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59975/merge:

Everything looks good!

Only pad initializer types for parameters without annotations

b836d23

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Sep 15, 2024

Andarist mentioned this pull request Sep 15, 2024

Binding element incorrectly reported as having any type in JS with JSDoc starting with 5.6.2 #59936

Open

burtek mentioned this pull request Sep 15, 2024

chore(deps): update dependency typescript to ~5.6.0 (master) burtek/eslint-config#154

Open

1 task

dont pad contextually-typed parameters either

909bac2

Andarist changed the title ~~Only pad initializer types for parameters without annotations~~ Only pad initializer types for parameters without annotations and contextual signatures Sep 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only pad initializer types for parameters without annotations and contextual signatures #59975

Only pad initializer types for parameters without annotations and contextual signatures #59975

Andarist commented Sep 15, 2024

jakebailey commented Sep 16, 2024

typescript-bot commented Sep 16, 2024 •

edited

Loading

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

tsc

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

Only pad initializer types for parameters without annotations and contextual signatures #59975

Are you sure you want to change the base?

Only pad initializer types for parameters without annotations and contextual signatures #59975

Conversation

Andarist commented Sep 15, 2024

jakebailey commented Sep 16, 2024

typescript-bot commented Sep 16, 2024 • edited Loading

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

tsc

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024 •

edited

Loading