Fixed single signature type instantiations leaking between calls with different mappers #59972

Andarist · 2024-09-15T09:41:11Z

… different mappers

Andarist · 2024-09-15T09:42:41Z

tests/cases/compiler/genericCallInferenceInConditionalTypes1.ts

+// the first one here has a chance to pollute the cache
+type Result1 = ComponentProps<typeof ComponentWithForwardRef>;
+// that could be incorrectly reused by this one
+type Result2 = Test<{ component: typeof ComponentWithForwardRef }>; // no `T` leak


in the process of resolving the first conditional type here a result with a conditional type's restrictive mapper was cached, then when resolving the second conditional type that cached result was reused incorrectly, failing to produce a type with its correct mapper applied to it

Andarist · 2024-09-15T09:48:15Z

src/compiler/checker.ts

-                if (type.objectFlags & ObjectFlags.SingleSignatureType) {
-                    result = instantiateAnonymousType(type, mapper);
-                    target.instantiations.set(id, result);
-                    return result;
-                }


It might feel like a downgrade that those are not cached right now. getObjectTypeInstantiation (the containing function) is only called from a single place and all the functions called from the branch leading to getObjectTypeInstantiation are implementing instantiation caching (createNormalizedTypeReference, instantiateReverseMappedType and getObjectTypeInstantiation).

But now not the branch I added - the one that calls instantiateAnonymousType for single signature types. I have no idea what I would use to create the cache key there. The only unique bits there are the results of the mapper but mapper isn't exactly called eagerly there so it doesn't have access to those.

However, I have a feeling that perhaps caching is already - sort of - implemented for those single signature types. It's just at a different level, like in the getReturnTypeOfSignature.

jakebailey · 2024-09-16T20:14:42Z

@typescript-bot test it

typescript-bot · 2024-09-16T20:14:46Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-16T21:00:28Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,620k (± 0.93%)}	_{193,083k (± 0.73%)}	_~	_192,403k	_195,958k	_{p=0.810 n=6}
_{Parse Time}	_{1.57s (± 1.12%)}	_{1.56s (± 1.02%)}	_~	_1.54s	_1.58s	_{p=0.801 n=6}
_{Bind Time}	_{0.86s (± 0.95%)}	_{0.86s (± 1.20%)}	_~	_0.85s	_0.87s	_{p=0.928 n=6}
_{Check Time}	_{11.42s (± 0.36%)}	_{11.39s (± 0.47%)}	_~	_11.31s	_11.45s	_{p=0.572 n=6}
_{Emit Time}	_{3.23s (± 0.51%)}	_{3.22s (± 0.75%)}	_~	_3.18s	_3.24s	_{p=0.742 n=6}
_{Total Time}	_{17.07s (± 0.23%)}	_{17.03s (± 0.36%)}	_~	_16.92s	_17.08s	_{p=0.229 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,733k (± 0.00%)}	_{1,222,744k (± 0.00%)}	_~	_1,222,683k	_1,222,829k	_{p=0.872 n=6}
_{Parse Time}	_{7.89s (± 0.70%)}	_{7.88s (± 0.51%)}	_~	_7.82s	_7.92s	_{p=0.565 n=6}
_{Bind Time}	_{2.22s (± 0.18%)}	_{2.22s (± 0.62%)}	_~	_2.19s	_2.23s	_{p=0.924 n=6}
_{Check Time}	_{36.38s (± 0.38%)}	_{36.40s (± 0.22%)}	_~	_36.28s	_36.53s	_{p=1.000 n=6}
_{Emit Time}	_{17.75s (± 0.56%)}	_{17.79s (± 0.35%)}	_~	_17.68s	_17.85s	_{p=0.810 n=6}
_{Total Time}	_{64.24s (± 0.31%)}	_{64.28s (± 0.17%)}	_~	_64.15s	_64.42s	_{p=0.748 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,520,527	_2,520,527	_~	_~	_~	_{p=1.000 n=6}
_Types	_935,974	_935,974	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,350,484k (± 0.00%)}	_{2,350,498k (± 0.00%)}	_~	_2,350,477k	_2,350,516k	_{p=0.810 n=6}
_{Parse Time}	_{13.59s (± 0.34%)}	_{13.59s (± 0.36%)}	_~	_13.53s	_13.65s	_{p=0.936 n=6}
_{Bind Time}	_{3.16s (± 0.55%)}	_{3.16s (± 0.65%)}	_~	_3.12s	_3.18s	_{p=0.935 n=6}
_{Check Time}	_{105.85s (± 0.40%)}	_{106.05s (± 0.55%)}	_~	_105.20s	_106.77s	_{p=0.689 n=6}
_{Emit Time}	_{0.39s (± 3.49%)}	_{0.38s (± 2.17%)}	_~	_0.38s	_0.40s	_{p=0.197 n=6}
_{Total Time}	_{122.98s (± 0.34%)}	_{123.18s (± 0.47%)}	_~	_122.32s	_123.97s	_{p=0.630 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,245,952	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,213	_264,212	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,397,537k (± 0.02%)}	_{2,399,250k (± 0.10%)}	_{+1,713k (+ 0.07%)}	_2,397,663k	_2,404,213k	_{p=0.031 n=6}
_{Parse Time}	_{7.61s (± 0.52%)}	_{7.61s (± 0.31%)}	_~	_7.58s	_7.64s	_{p=0.574 n=6}
_{Bind Time}	_{2.80s (± 0.64%)}	_{2.80s (± 0.66%)}	_~	_2.79s	_2.84s	_{p=0.572 n=6}
_{Check Time}	_{51.07s (± 0.42%)}	_{50.78s (± 0.73%)}	_~	_50.36s	_51.23s	_{p=0.173 n=6}
_{Emit Time}	_{4.46s (± 1.36%)}	_{4.37s (± 1.39%)}	_{-0.09s (- 1.98%)}	_4.26s	_4.42s	_{p=0.037 n=6}
_{Total Time}	_{65.95s (± 0.32%)}	_{65.57s (± 0.64%)}	_~	_65.09s	_66.04s	_{p=0.093 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,245,952	_1,245,952	_~	_~	_~	_{p=1.000 n=6}
_Types	_264,213	_264,212	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,472,025k (± 0.04%)}	_{2,471,595k (± 0.03%)}	_~	_2,470,998k	_2,473,192k	_{p=0.575 n=6}
_{Parse Time}	_{6.27s (± 0.44%)}	_{6.28s (± 0.38%)}	_~	_6.25s	_6.31s	_{p=0.520 n=6}
_{Bind Time}	_{2.02s (± 0.52%)}	_{2.03s (± 0.37%)}	_~	_2.02s	_2.04s	_{p=1.000 n=6}
_{Check Time}	_{41.51s (± 0.66%)}	_{41.45s (± 0.79%)}	_~	_41.05s	_41.90s	_{p=0.936 n=6}
_{Emit Time}	_{3.57s (± 1.71%)}	_{3.71s (± 2.95%)}	_{+0.14s (+ 3.92%)}	_3.61s	_3.88s	_{p=0.013 n=6}
_{Total Time}	_{53.39s (± 0.60%)}	_{53.48s (± 0.44%)}	_~	_53.20s	_53.89s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,885	_259,885	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,140	_106,139	_{-1 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{435,572k (± 0.01%)}	_{435,567k (± 0.02%)}	_~	_435,449k	_435,643k	_{p=1.000 n=6}
_{Parse Time}	_{2.84s (± 0.61%)}	_{2.85s (± 0.62%)}	_~	_2.82s	_2.87s	_{p=0.803 n=6}
_{Bind Time}	_{1.08s (± 1.12%)}	_{1.07s (± 1.13%)}	_~	_1.06s	_1.09s	_{p=0.070 n=6}
_{Check Time}	_{15.39s (± 0.26%)}	_{15.37s (± 0.25%)}	_~	_15.30s	_15.40s	_{p=0.260 n=6}
_{Emit Time}	_{1.30s (± 0.90%)}	_{1.28s (± 1.54%)}	_{-0.02s (- 1.92%)}	_1.25s	_1.30s	_{p=0.040 n=6}
_{Total Time}	_{20.61s (± 0.29%)}	_{20.55s (± 0.20%)}	_~	_20.51s	_20.61s	_{p=0.092 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,265k (± 0.02%)}	_{370,252k (± 0.02%)}	_~	_370,167k	_370,337k	_{p=0.810 n=6}
_{Parse Time}	_{2.28s (± 0.60%)}	_{2.28s (± 0.71%)}	_~	_2.26s	_2.31s	_{p=0.867 n=6}
_{Bind Time}	_{1.31s (± 0.57%)}	_{1.31s (± 2.31%)}	_~	_1.29s	_1.37s	_{p=0.187 n=6}
_{Check Time}	_{13.37s (± 0.29%)}	_{13.38s (± 0.22%)}	_~	_13.35s	_13.43s	_{p=0.808 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{16.96s (± 0.26%)}	_{16.97s (± 0.30%)}	_~	_16.93s	_17.07s	_{p=1.000 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,067,616	_3,067,616	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,059,253	_1,059,253	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,173,020k (± 0.00%)}	_{3,173,042k (± 0.00%)}	_~	_3,172,980k	_3,173,111k	_{p=0.936 n=6}
_{Parse Time}	_{13.91s (± 0.41%)}	_{13.91s (± 0.09%)}	_~	_13.90s	_13.93s	_{p=0.467 n=6}
_{Bind Time}	_{4.42s (± 2.61%)}	_{4.39s (± 2.08%)}	_~	_4.35s	_4.58s	_{p=0.366 n=6}
_{Check Time}	_{81.61s (± 0.40%)}	_{81.64s (± 0.28%)}	_~	_81.29s	_81.91s	_{p=0.936 n=6}
_{Emit Time}	_{22.25s (± 0.33%)}	_{22.30s (± 0.44%)}	_~	_22.18s	_22.41s	_{p=0.470 n=6}
_{Total Time}	_{122.19s (± 0.36%)}	_{122.25s (± 0.25%)}	_~	_121.79s	_122.60s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,156	_277,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,946	_112,946	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,007k (± 0.04%)}	_{427,014k (± 0.01%)}	_~	_426,966k	_427,107k	_{p=0.630 n=6}
_{Parse Time}	_{4.92s (± 0.46%)}	_{4.91s (± 0.36%)}	_~	_4.88s	_4.93s	_{p=0.372 n=6}
_{Bind Time}	_{2.14s (± 1.04%)}	_{2.12s (± 0.97%)}	_~	_2.08s	_2.14s	_{p=0.063 n=6}
_{Check Time}	_{21.84s (± 0.40%)}	_{21.77s (± 0.50%)}	_~	_21.62s	_21.89s	_{p=0.376 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.90s (± 0.18%)}	_{28.79s (± 0.39%)}	_~	_28.67s	_28.95s	_{p=0.106 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_531,582	_531,582	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,676	_181,676	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,694k (± 0.00%)}	_{463,747k (± 0.02%)}	_~	_463,666k	_463,879k	_{p=0.065 n=6}
_{Parse Time}	_{2.61s (± 0.51%)}	_{2.60s (± 0.49%)}	_~	_2.59s	_2.62s	_{p=0.318 n=6}
_{Bind Time}	_0.93s	_{0.93s (± 0.44%)}	_~	_0.93s	_0.94s	_{p=0.405 n=6}
_{Check Time}	_{15.45s (± 0.50%)}	_{15.44s (± 0.39%)}	_~	_15.36s	_15.52s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.98s (± 0.44%)}	_{18.97s (± 0.33%)}	_~	_18.88s	_19.04s	_{p=0.873 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-16T21:01:00Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-16T21:15:09Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59972/merge:

Everything looks good!

typescript-bot · 2024-09-16T22:15:34Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59972/merge:

Everything looks good!

Fixed single signature type instantiations leaking between calls with…

c8d92fa

… different mappers

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Sep 15, 2024

Andarist commented Sep 15, 2024

View reviewed changes

Andarist mentioned this pull request Sep 15, 2024

React's ComponentProps type issues in TypeScript 5.6.2 #59937

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed single signature type instantiations leaking between calls with different mappers #59972

Fixed single signature type instantiations leaking between calls with different mappers #59972

Andarist commented Sep 15, 2024 •

edited

Loading

Andarist Sep 15, 2024

Andarist Sep 15, 2024

jakebailey commented Sep 16, 2024

typescript-bot commented Sep 16, 2024 •

edited

Loading

typescript-bot commented Sep 16, 2024

tsc

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

Fixed single signature type instantiations leaking between calls with different mappers #59972

Are you sure you want to change the base?

Fixed single signature type instantiations leaking between calls with different mappers #59972

Conversation

Andarist commented Sep 15, 2024 • edited Loading

Andarist Sep 15, 2024

Choose a reason for hiding this comment

Andarist Sep 15, 2024

Choose a reason for hiding this comment

jakebailey commented Sep 16, 2024

typescript-bot commented Sep 16, 2024 • edited Loading

typescript-bot commented Sep 16, 2024

tsc

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

typescript-bot commented Sep 16, 2024

Andarist commented Sep 15, 2024 •

edited

Loading

typescript-bot commented Sep 16, 2024 •

edited

Loading