Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tsbuildInfo specification error now that we need it for non incremental scenarios as well and there is no way to disable it #59960

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

sheetalkamat
Copy link
Member

Fixes #59958

…cremental scenarios as well and there is no way to disable it

Fixes #59958
@sheetalkamat
Copy link
Member Author

@DanielRosenwasser we probably want this for 5.6 patch

@sheetalkamat sheetalkamat merged commit 49ad1a3 into main Sep 18, 2024
31 of 32 checks passed
@sheetalkamat sheetalkamat deleted the noErrorOnTsbuildInfo branch September 18, 2024 17:42
@jakebailey
Copy link
Member

@typescript-bot cherry-pick this to release-5.6

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 18, 2024

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
cherry-pick this to release-5.6 ✅ Started ❌ Results

@typescript-bot
Copy link
Collaborator

Hey, @jakebailey! I was unable to cherry-pick this PR.

Check the logs at: https://github.com/microsoft/TypeScript/actions/runs/10927384763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

tsBuildInfoFile compiler option should be allowed without incremental or composite in Typescript versions >5.6
3 participants