Use lookup tables for common functions on node kinds. #59954

DanielRosenwasser · 2024-09-13T06:08:51Z

No description provided.

DanielRosenwasser · 2024-09-13T06:09:03Z

typescript-bot · 2024-09-13T06:09:07Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-09-13T06:53:07Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,382k (± 0.03%)}	_{193,113k (± 0.78%)}	_~	_192,404k	_196,188k	_{p=0.093 n=6}
_{Parse Time}	_{1.58s (± 0.65%)}	_{1.57s (± 1.33%)}	_~	_1.55s	_1.60s	_{p=0.516 n=6}
_{Bind Time}	_{0.86s (± 1.20%)}	_{0.85s (± 1.43%)}	_~	_0.83s	_0.86s	_{p=0.180 n=6}
_{Check Time}	_{11.38s (± 0.47%)}	_{11.36s (± 0.34%)}	_~	_11.29s	_11.39s	_{p=0.170 n=6}
_{Emit Time}	_{3.23s (± 0.82%)}	_{3.28s (± 0.53%)}	_{+0.05s (+ 1.39%)}	_3.25s	_3.29s	_{p=0.014 n=6}
_{Total Time}	_{17.05s (± 0.32%)}	_{17.05s (± 0.32%)}	_~	_16.97s	_17.13s	_{p=0.809 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,762k (± 0.00%)}	_{1,222,772k (± 0.00%)}	_~	_1,222,705k	_1,222,819k	_{p=0.575 n=6}
_{Parse Time}	_{6.68s (± 0.46%)}	_{6.68s (± 0.26%)}	_~	_6.65s	_6.70s	_{p=0.934 n=6}
_{Bind Time}	_{1.87s (± 0.45%)}	_{1.85s (± 0.34%)}	_{-0.01s (- 0.80%)}	_1.84s	_1.86s	_{p=0.018 n=6}
_{Check Time}	_{31.20s (± 0.30%)}	_{31.36s (± 1.07%)}	_~	_31.13s	_31.98s	_{p=0.575 n=6}
_{Emit Time}	_{15.10s (± 0.49%)}	_{15.08s (± 0.99%)}	_~	_14.82s	_15.25s	_{p=1.000 n=6}
_{Total Time}	_{54.85s (± 0.24%)}	_{54.98s (± 0.72%)}	_~	_54.57s	_55.67s	_{p=0.630 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,234	_2,529,234	_~	_~	_~	_{p=1.000 n=6}
_Types	_935,840	_935,840	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,364,184k (± 0.00%)}	_{2,364,281k (± 0.00%)}	_{+97k (+ 0.00%)}	_2,364,239k	_2,364,343k	_{p=0.005 n=6}
_{Parse Time}	_{11.16s (± 0.27%)}	_{11.16s (± 0.28%)}	_~	_11.13s	_11.21s	_{p=1.000 n=6}
_{Bind Time}	_{2.62s (± 0.95%)}	_{2.60s (± 0.29%)}	_~	_2.59s	_2.61s	_{p=0.118 n=6}
_{Check Time}	_{86.23s (± 0.72%)}	_{86.46s (± 0.42%)}	_~	_86.11s	_87.00s	_{p=0.810 n=6}
_{Emit Time}	_{0.33s (± 1.58%)}	_0.33s	_~	_~	_~	_{p=0.174 n=6}
_{Total Time}	_{100.33s (± 0.63%)}	_{100.55s (± 0.35%)}	_~	_100.20s	_101.07s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,418	_1,250,464	_{+46 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,229	_265,252	_{+23 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,403,396k (± 0.04%)}	_{2,403,117k (± 0.03%)}	_~	_2,402,098k	_2,404,002k	_{p=0.471 n=6}
_{Parse Time}	_{6.10s (± 0.74%)}	_{6.08s (± 1.04%)}	_~	_5.99s	_6.15s	_{p=0.936 n=6}
_{Bind Time}	_{2.28s (± 0.43%)}	_{2.26s (± 0.63%)}	_~	_2.24s	_2.28s	_{p=0.085 n=6}
_{Check Time}	_{41.01s (± 0.65%)}	_{41.20s (± 0.68%)}	_~	_40.97s	_41.69s	_{p=0.230 n=6}
_{Emit Time}	_{3.94s (± 1.50%)}	_{4.05s (± 3.87%)}	_~	_3.92s	_4.31s	_{p=0.423 n=6}
_{Total Time}	_{53.35s (± 0.61%)}	_{53.61s (± 0.52%)}	_~	_53.24s	_54.00s	_{p=0.109 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,418	_1,250,464	_{+46 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,229	_265,252	_{+23 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,478,014k (± 0.04%)}	_{2,477,795k (± 0.04%)}	_~	_2,476,930k	_2,479,546k	_{p=0.471 n=6}
_{Parse Time}	_{7.82s (± 0.66%)}	_{7.83s (± 0.80%)}	_~	_7.74s	_7.89s	_{p=0.689 n=6}
_{Bind Time}	_{2.53s (± 0.30%)}	_{2.52s (± 1.56%)}	_~	_2.47s	_2.56s	_{p=1.000 n=6}
_{Check Time}	_{51.28s (± 0.91%)}	_{51.21s (± 0.58%)}	_~	_50.96s	_51.69s	_{p=0.936 n=6}
_{Emit Time}	_{4.90s (± 0.48%)}	_{4.99s (± 4.67%)}	_~	_4.73s	_5.42s	_{p=0.520 n=6}
_{Total Time}	_{66.56s (± 0.71%)}	_{66.56s (± 0.53%)}	_~	_66.01s	_67.01s	_{p=1.000 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,449	_259,495	_{+46 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,986	_106,009	_{+23 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{433,840k (± 0.01%)}	_{433,937k (± 0.03%)}	_~	_433,858k	_434,232k	_{p=0.230 n=6}
_{Parse Time}	_{3.42s (± 0.82%)}	_{3.41s (± 0.75%)}	_~	_3.38s	_3.44s	_{p=0.468 n=6}
_{Bind Time}	_{1.27s (± 0.43%)}	_{1.26s (± 1.08%)}	_~	_1.25s	_1.29s	_{p=0.057 n=6}
_{Check Time}	_{18.12s (± 0.59%)}	_{18.15s (± 0.27%)}	_~	_18.07s	_18.21s	_{p=0.336 n=6}
_{Emit Time}	_{1.65s (± 1.29%)}	_{1.64s (± 0.67%)}	_~	_1.63s	_1.66s	_{p=0.252 n=6}
_{Total Time}	_{24.47s (± 0.33%)}	_{24.46s (± 0.23%)}	_~	_24.38s	_24.53s	_{p=1.000 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,215k (± 0.02%)}	_{370,246k (± 0.02%)}	_~	_370,178k	_370,390k	_{p=0.936 n=6}
_{Parse Time}	_{3.43s (± 0.80%)}	_{3.42s (± 0.31%)}	_~	_3.41s	_3.44s	_{p=1.000 n=6}
_{Bind Time}	_{1.91s (± 1.38%)}	_{1.92s (± 0.55%)}	_~	_1.90s	_1.93s	_{p=0.935 n=6}
_{Check Time}	_{19.50s (± 0.61%)}	_{19.43s (± 0.36%)}	_~	_19.34s	_19.52s	_{p=0.377 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.85s (± 0.41%)}	_{24.77s (± 0.29%)}	_~	_24.67s	_24.87s	_{p=0.261 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,060,029	_3,060,029	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,057,381	_1,057,381	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,167,349k (± 0.00%)}	_{3,167,382k (± 0.00%)}	_~	_3,167,280k	_3,167,477k	_{p=0.575 n=6}
_{Parse Time}	_{13.85s (± 0.53%)}	_{13.82s (± 0.38%)}	_~	_13.74s	_13.88s	_{p=0.575 n=6}
_{Bind Time}	_{4.31s (± 0.25%)}	_{4.26s (± 0.28%)}	_{-0.05s (- 1.24%)}	_4.24s	_4.27s	_{p=0.004 n=6}
_{Check Time}	_{81.22s (± 0.28%)}	_{81.05s (± 0.24%)}	_~	_80.70s	_81.20s	_{p=0.261 n=6}
_{Emit Time}	_{22.03s (± 0.48%)}	_{22.08s (± 0.40%)}	_~	_21.95s	_22.19s	_{p=0.470 n=6}
_{Total Time}	_{121.42s (± 0.21%)}	_{121.20s (± 0.17%)}	_~	_120.81s	_121.35s	_{p=0.377 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,156	_277,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,946	_112,946	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,959k (± 0.02%)}	_{427,023k (± 0.02%)}	_~	_426,952k	_427,189k	_{p=0.298 n=6}
_{Parse Time}	_{4.91s (± 0.61%)}	_{4.87s (± 0.48%)}	_~	_4.84s	_4.90s	_{p=0.053 n=6}
_{Bind Time}	_{2.13s (± 0.69%)}	_{2.09s (± 0.99%)}	_{-0.04s (- 1.72%)}	_2.07s	_2.12s	_{p=0.012 n=6}
_{Check Time}	_{21.87s (± 0.40%)}	_{21.97s (± 0.26%)}	_~	_21.88s	_22.04s	_{p=0.078 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.91s (± 0.30%)}	_{28.94s (± 0.21%)}	_~	_28.87s	_29.01s	_{p=0.520 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_539,317	_539,317	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,997	_178,997	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{484,323k (± 0.02%)}	_{484,217k (± 0.02%)}	_~	_484,069k	_484,317k	_{p=0.128 n=6}
_{Parse Time}	_{2.84s (± 0.43%)}	_{2.84s (± 0.35%)}	_~	_2.83s	_2.85s	_{p=0.865 n=6}
_{Bind Time}	_1.05s	_{1.04s (± 0.79%)}	_{-0.01s (- 1.27%)}	_1.02s	_1.04s	_{p=0.002 n=6}
_{Check Time}	_{15.49s (± 0.32%)}	_{15.53s (± 0.39%)}	_~	_15.47s	_15.63s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.39s (± 0.28%)}	_{19.41s (± 0.33%)}	_~	_19.35s	_19.52s	_{p=0.748 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,286ms (± 1.32%)}	_{2,291ms (± 0.56%)}	_~	_2,274ms	_2,302ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{5,176ms (± 0.55%)}	_{5,182ms (± 0.40%)}	_~	_5,164ms	_5,220ms	_{p=0.689 n=6}
_{Req 3 - references}	_{261ms (± 0.61%)}	_{287ms (± 0.48%)}	_{🔻+25ms (+ 9.70%)}	_285ms	_288ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{227ms (± 0.48%)}	_{225ms (± 0.67%)}	_~	_223ms	_227ms	_{p=0.063 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{85ms (± 6.20%)}	_{86ms (± 3.74%)}	_~	_80ms	_90ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,399ms (± 1.22%)}	_{2,420ms (± 0.47%)}	_~	_2,409ms	_2,439ms	_{p=0.066 n=6}
_{Req 2 - geterr}	_{3,918ms (± 0.16%)}	_{3,921ms (± 0.23%)}	_~	_3,908ms	_3,933ms	_{p=0.630 n=6}
_{Req 3 - references}	_{275ms (± 1.02%)}	_{298ms (± 0.60%)}	_{🔻+23ms (+ 8.23%)}	_295ms	_300ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{227ms (± 0.28%)}	_{226ms (± 0.53%)}	_~	_225ms	_228ms	_{p=0.344 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 6.12%)}	_{79ms (± 7.54%)}	_~	_73ms	_86ms	_{p=0.222 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{7,729ms (± 0.30%)}	_{7,734ms (± 0.09%)}	_~	_7,723ms	_7,743ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{1,685ms (± 1.01%)}	_{1,696ms (± 1.24%)}	_~	_1,678ms	_1,733ms	_{p=0.521 n=6}
_{Req 3 - references}	_{127ms (± 0.81%)}	_{127ms (± 1.07%)}	_~	_126ms	_129ms	_{p=0.933 n=6}
_{Req 4 - navto}	_{596ms (± 2.13%)}	_{603ms (± 2.10%)}	_~	_585ms	_622ms	_{p=0.378 n=6}
_{Req 5 - completionInfo count}	_3,444	_3,444	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{1,272ms (± 1.30%)}	_{1,269ms (± 0.41%)}	_~	_1,259ms	_1,274ms	_{p=0.630 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{158.40ms (± 0.17%)}	_{158.38ms (± 0.19%)}	_~	_157.24ms	_162.92ms	_{p=0.155 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{232.26ms (± 0.13%)}	_{232.41ms (± 0.13%)}	_{+0.15ms (+ 0.06%)}	_231.15ms	_236.03ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{279.03ms (± 0.28%)}	_{279.21ms (± 0.28%)}	_{+0.18ms (+ 0.06%)}	_272.28ms	_285.68ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.36ms (± 0.16%)}	_{227.59ms (± 0.22%)}	_{+0.23ms (+ 0.10%)}	_226.12ms	_244.21ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

DanielRosenwasser · 2024-09-13T07:28:22Z

@typescript-bot perf test this

typescript-bot · 2024-09-13T07:28:25Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`perf test this`	✅ Started	👀 Results

typescript-bot · 2024-09-13T08:13:35Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,203k (± 0.73%)}	_{193,731k (± 0.95%)}	_~	_192,438k	_196,172k	_{p=0.936 n=6}
_{Parse Time}	_{1.57s (± 0.80%)}	_{1.58s (± 1.48%)}	_~	_1.55s	_1.61s	_{p=0.935 n=6}
_{Bind Time}	_{0.86s (± 0.88%)}	_{0.85s (± 1.21%)}	_~	_0.84s	_0.87s	_{p=0.351 n=6}
_{Check Time}	_{11.37s (± 0.28%)}	_{11.39s (± 0.42%)}	_~	_11.33s	_11.45s	_{p=0.519 n=6}
_{Emit Time}	_{3.22s (± 1.51%)}	_{3.24s (± 0.50%)}	_~	_3.22s	_3.27s	_{p=0.510 n=6}
_{Total Time}	_{17.01s (± 0.36%)}	_{17.06s (± 0.27%)}	_~	_17.01s	_17.12s	_{p=0.226 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,753	_945,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,067	_410,067	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,726k (± 0.00%)}	_{1,222,788k (± 0.00%)}	_{+62k (+ 0.01%)}	_1,222,735k	_1,222,857k	_{p=0.013 n=6}
_{Parse Time}	_{7.91s (± 0.50%)}	_{7.92s (± 0.23%)}	_~	_7.90s	_7.95s	_{p=0.418 n=6}
_{Bind Time}	_{2.23s (± 0.34%)}	_{2.21s (± 0.37%)}	_{-0.02s (- 0.97%)}	_2.20s	_2.22s	_{p=0.007 n=6}
_{Check Time}	_{36.40s (± 0.47%)}	_{36.46s (± 0.30%)}	_~	_36.32s	_36.60s	_{p=0.378 n=6}
_{Emit Time}	_{17.89s (± 0.52%)}	_{17.89s (± 0.59%)}	_~	_17.77s	_18.07s	_{p=1.000 n=6}
_{Total Time}	_{64.43s (± 0.35%)}	_{64.48s (± 0.31%)}	_~	_64.20s	_64.70s	_{p=0.689 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,529,274	_2,529,274	_~	_~	_~	_{p=1.000 n=6}
_Types	_935,839	_935,839	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,364,198k (± 0.00%)}	_{2,364,285k (± 0.00%)}	_{+87k (+ 0.00%)}	_2,364,236k	_2,364,350k	_{p=0.005 n=6}
_{Parse Time}	_{11.15s (± 0.41%)}	_{11.14s (± 0.10%)}	_~	_11.13s	_11.16s	_{p=0.256 n=6}
_{Bind Time}	_{2.61s (± 0.45%)}	_{2.58s (± 0.35%)}	_{-0.03s (- 1.21%)}	_2.57s	_2.59s	_{p=0.005 n=6}
_{Check Time}	_{86.36s (± 0.53%)}	_{86.14s (± 0.22%)}	_~	_85.96s	_86.50s	_{p=0.521 n=6}
_{Emit Time}	_{0.33s (± 1.23%)}	_{0.33s (± 1.91%)}	_~	_0.32s	_0.34s	_{p=0.673 n=6}
_{Total Time}	_{100.45s (± 0.45%)}	_{100.20s (± 0.20%)}	_~	_99.99s	_100.57s	_{p=0.378 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,418	_1,250,466	_{+48 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,229	_265,141	_{-88 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,403,295k (± 0.05%)}	_{2,641,156k (±13.95%)}	_~	_2,402,279k	_3,117,944k	_{p=0.471 n=6}
_{Parse Time}	_{6.10s (± 0.85%)}	_{6.15s (± 1.45%)}	_~	_6.03s	_6.30s	_{p=0.296 n=6}
_{Bind Time}	_{2.27s (± 0.99%)}	_{2.24s (± 0.99%)}	_{-0.03s (- 1.39%)}	_2.21s	_2.28s	_{p=0.027 n=6}
_{Check Time}	_{40.90s (± 0.51%)}	_{41.17s (± 0.52%)}	_~	_40.79s	_41.33s	_{p=0.093 n=6}
_{Emit Time}	_{4.03s (± 4.38%)}	_{4.01s (± 1.92%)}	_~	_3.92s	_4.15s	_{p=0.810 n=6}
_{Total Time}	_{53.32s (± 0.47%)}	_{53.58s (± 0.32%)}	_~	_53.34s	_53.82s	_{p=0.066 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,418	_1,250,466	_{+48 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,229	_265,141	_{-88 (- 0.03%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,478,058k (± 0.05%)}	_{2,478,106k (± 0.04%)}	_~	_2,477,109k	_2,479,363k	_{p=0.936 n=6}
_{Parse Time}	_{7.87s (± 1.11%)}	_{7.86s (± 0.98%)}	_~	_7.78s	_7.99s	_{p=0.810 n=6}
_{Bind Time}	_{2.53s (± 0.46%)}	_{2.51s (± 0.53%)}	_{-0.02s (- 0.79%)}	_2.49s	_2.53s	_{p=0.032 n=6}
_{Check Time}	_{51.35s (± 0.97%)}	_{50.96s (± 0.55%)}	_{-0.39s (- 0.75%)}	_50.66s	_51.49s	_{p=0.031 n=6}
_{Emit Time}	_{5.01s (± 3.18%)}	_{5.08s (± 5.17%)}	_~	_4.80s	_5.40s	_{p=0.936 n=6}
_{Total Time}	_{66.77s (± 0.75%)}	_{66.40s (± 0.63%)}	_~	_65.80s	_66.88s	_{p=0.298 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,449	_259,497	_{+48 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,986	_105,898	_{-88 (- 0.08%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{433,909k (± 0.02%)}	_{433,601k (± 0.01%)}	_{-308k (- 0.07%)}	_433,576k	_433,630k	_{p=0.005 n=6}
_{Parse Time}	_{3.43s (± 0.75%)}	_{3.40s (± 0.97%)}	_~	_3.37s	_3.46s	_{p=0.170 n=6}
_{Bind Time}	_{1.28s (± 0.59%)}	_{1.26s (± 0.41%)}	_{-0.01s (- 1.17%)}	_1.26s	_1.27s	_{p=0.010 n=6}
_{Check Time}	_{18.09s (± 0.31%)}	_{17.99s (± 0.31%)}	_{-0.11s (- 0.59%)}	_17.90s	_18.06s	_{p=0.016 n=6}
_{Emit Time}	_{1.65s (± 0.51%)}	_{1.65s (± 0.99%)}	_~	_1.63s	_1.67s	_{p=1.000 n=6}
_{Total Time}	_{24.44s (± 0.13%)}	_{24.30s (± 0.28%)}	_{-0.15s (- 0.60%)}	_24.19s	_24.37s	_{p=0.005 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,018	_225,018	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,249	_94,249	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,211k (± 0.02%)}	_{370,272k (± 0.02%)}	_~	_370,172k	_370,401k	_{p=0.378 n=6}
_{Parse Time}	_{3.45s (± 1.19%)}	_{3.43s (± 0.77%)}	_~	_3.39s	_3.47s	_{p=0.418 n=6}
_{Bind Time}	_{1.93s (± 1.20%)}	_{1.91s (± 0.80%)}	_~	_1.88s	_1.92s	_{p=0.059 n=6}
_{Check Time}	_{19.44s (± 0.26%)}	_{19.46s (± 0.29%)}	_~	_19.41s	_19.55s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.82s (± 0.21%)}	_{24.79s (± 0.27%)}	_~	_24.70s	_24.90s	_{p=0.261 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,060,029	_3,060,029	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,057,381	_1,057,381	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,167,363k (± 0.00%)}	_{3,167,457k (± 0.00%)}	_{+94k (+ 0.00%)}	_3,167,408k	_3,167,501k	_{p=0.013 n=6}
_{Parse Time}	_{13.84s (± 0.23%)}	_{13.83s (± 0.35%)}	_~	_13.78s	_13.91s	_{p=0.687 n=6}
_{Bind Time}	_{4.32s (± 1.10%)}	_{4.26s (± 0.35%)}	_{-0.06s (- 1.43%)}	_4.24s	_4.28s	_{p=0.005 n=6}
_{Check Time}	_{81.03s (± 0.33%)}	_{80.88s (± 0.24%)}	_~	_80.58s	_81.07s	_{p=0.296 n=6}
_{Emit Time}	_{22.03s (± 0.71%)}	_{22.04s (± 0.41%)}	_~	_21.93s	_22.17s	_{p=1.000 n=6}
_{Total Time}	_{121.23s (± 0.33%)}	_{121.01s (± 0.25%)}	_~	_120.58s	_121.30s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_277,156	_277,156	_~	_~	_~	_{p=1.000 n=6}
_Types	_112,946	_112,946	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{426,942k (± 0.02%)}	_{427,020k (± 0.01%)}	_~	_426,976k	_427,092k	_{p=0.148 n=6}
_{Parse Time}	_{4.90s (± 0.55%)}	_{4.87s (± 0.35%)}	_~	_4.84s	_4.89s	_{p=0.053 n=6}
_{Bind Time}	_{2.15s (± 0.62%)}	_{2.11s (± 0.39%)}	_{-0.04s (- 1.94%)}	_2.10s	_2.12s	_{p=0.004 n=6}
_{Check Time}	_{21.76s (± 0.37%)}	_{21.98s (± 0.48%)}	_{+0.22s (+ 1.00%)}	_21.83s	_22.14s	_{p=0.008 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.81s (± 0.32%)}	_{28.96s (± 0.41%)}	_~	_28.79s	_29.13s	_{p=0.064 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_539,317	_539,317	_~	_~	_~	_{p=1.000 n=6}
_Types	_178,997	_178,997	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{484,263k (± 0.03%)}	_{484,286k (± 0.03%)}	_~	_484,159k	_484,461k	_{p=1.000 n=6}
_{Parse Time}	_{2.84s (± 0.61%)}	_{2.82s (± 0.61%)}	_~	_2.80s	_2.85s	_{p=0.146 n=6}
_{Bind Time}	_{1.04s (± 0.99%)}	_{1.03s (± 1.00%)}	_~	_1.02s	_1.04s	_{p=0.113 n=6}
_{Check Time}	_{15.50s (± 0.37%)}	_{15.53s (± 0.15%)}	_~	_15.50s	_15.55s	_{p=0.375 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.38s (± 0.25%)}	_{19.39s (± 0.17%)}	_~	_19.34s	_19.43s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,291ms (± 0.30%)}	_{2,297ms (± 0.52%)}	_~	_2,273ms	_2,305ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{5,173ms (± 0.57%)}	_{5,189ms (± 0.30%)}	_~	_5,172ms	_5,215ms	_{p=0.149 n=6}
_{Req 3 - references}	_{263ms (± 0.97%)}	_{284ms (± 0.26%)}	_{🔻+21ms (+ 8.12%)}	_283ms	_285ms	_{p=0.004 n=6}
_{Req 4 - navto}	_{227ms (± 0.18%)}	_{227ms (± 0.54%)}	_~	_224ms	_227ms	_{p=0.218 n=6}
_{Req 5 - completionInfo count}	_1,357	_1,357	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{80ms (± 5.76%)}	_{85ms (± 3.32%)}	_~	_79ms	_87ms	_{p=0.161 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,426ms (± 0.94%)}	_{2,425ms (± 0.66%)}	_~	_2,410ms	_2,454ms	_{p=0.936 n=6}
_{Req 2 - geterr}	_{3,926ms (± 0.15%)}	_{3,923ms (± 0.30%)}	_~	_3,902ms	_3,932ms	_{p=0.935 n=6}
_{Req 3 - references}	_{275ms (± 1.72%)}	_{294ms (± 0.47%)}	_{🔻+19ms (+ 6.92%)}	_292ms	_296ms	_{p=0.005 n=6}
_{Req 4 - navto}	_{232ms (± 2.73%)}	_{227ms (± 0.33%)}	_{-5ms (- 2.16%)}	_226ms	_228ms	_{p=0.024 n=6}
_{Req 5 - completionInfo count}	_1,519	_1,519	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{78ms (±10.80%)}	_{78ms (± 6.48%)}	_~	_74ms	_85ms	_{p=1.000 n=6}
_{xstate-main-1-tsserver - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{5,199ms (± 0.24%)}	_{5,174ms (± 0.43%)}	_~	_5,148ms	_5,208ms	_{p=0.066 n=6}
_{Req 2 - geterr}	_{1,128ms (± 0.87%)}	_{1,136ms (± 0.74%)}	_~	_1,127ms	_1,149ms	_{p=0.260 n=6}
_{Req 3 - references}	_{87ms (± 2.35%)}	_{86ms (± 5.16%)}	_~	_79ms	_91ms	_{p=0.787 n=6}
_{Req 4 - navto}	_{443ms (± 0.12%)}	_{442ms (± 0.19%)}	_{-1ms (- 0.26%)}	_441ms	_443ms	_{p=0.033 n=6}
_{Req 5 - completionInfo count}	_3,444	_3,444	_~	_~	_~	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{847ms (± 1.25%)}	_{848ms (± 0.93%)}	_~	_837ms	_856ms	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstate-main-1-tsserver - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{158.23ms (± 0.18%)}	_{158.41ms (± 0.19%)}	_{+0.17ms (+ 0.11%)}	_157.33ms	_163.38ms	_{p=0.000 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{233.31ms (± 0.13%)}	_{233.57ms (± 0.12%)}	_{+0.27ms (+ 0.11%)}	_232.29ms	_235.18ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{228.96ms (± 0.14%)}	_{229.37ms (± 0.14%)}	_{+0.41ms (+ 0.18%)}	_227.91ms	_233.63ms	_{p=0.000 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{227.27ms (± 0.20%)}	_{227.59ms (± 0.15%)}	_{+0.32ms (+ 0.14%)}	_226.24ms	_231.10ms	_{p=0.000 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

jakebailey · 2024-09-13T17:51:07Z

src/compiler/utilitiesPublic.ts

+    IsExpression = StrictlyMiscellaneousExpression | IsUnaryExpression,
+}
+
+const nodeKindFacts: NodeKindFacts[] = [];


I think you'd actually have better perf filling pre-filling this with numbers to get one of those special compact arrays

I'm pretty sure that happens today with push according to https://v8.dev/blog/elements-kinds and this test:

let x = []; console.log("Unfilled:"); %DebugPrint(x); for (let i = 0; i < 10; i++) { x.push(i); } console.log("Filled:"); %DebugPrint(x);

Output

Unfilled: DebugPrint: 0xcfb0004ab5d: [JSArray] - map: 0x0cfb0018e6b9 <Map[16](PACKED_SMI_ELEMENTS)> [FastProperties] - prototype: 0x0cfb0018e92d <JSArray[0]> - elements: 0x0cfb000006cd <FixedArray[0]> [PACKED_SMI_ELEMENTS] - length: 0 - properties: 0x0cfb000006cd <FixedArray[0]> - All own properties (excluding elements): { 0xcfb00000d41: [String] in ReadOnlySpace: #length: 0x0cfb0028741d <AccessorInfo name= 0x0cfb00000d41 <String[6]: #length>, data= 0x0cfb00000061 <undefined>> (const accessor descriptor), location: descriptor } 0xcfb0018e6b9: [Map] in OldSpace - map: 0x0cfb00183c35 <MetaMap (0x0cfb00183c85 <NativeContext[285]>)> - type: JS_ARRAY_TYPE - instance size: 16 - inobject properties: 0 - unused property fields: 0 - elements kind: PACKED_SMI_ELEMENTS - enum length: invalid - back pointer: 0x0cfb00000061 <undefined> - prototype_validity cell: 0x0cfb00000a31 <Cell value= 1> - instance descriptors #1: 0x0cfb0018ef45 <DescriptorArray[1]> - transitions #1: 0x0cfb0018ef61 <TransitionArray[4]>Transition array #1: 0x0cfb00000e05 <Symbol: (elements_transition_symbol)>: (transition to HOLEY_SMI_ELEMENTS) -> 0x0cfb0018ef79 <Map[16](HOLEY_SMI_ELEMENTS)> - prototype: 0x0cfb0018e92d <JSArray[0]> - constructor: 0x0cfb0018e625 <JSFunction Array (sfi = 0xcfb0028c6ad)> - dependent code: 0x0cfb000006dd <Other heap object (WEAK_ARRAY_LIST_TYPE)> - construction counter: 0 Filled: DebugPrint: 0xcfb0004ab5d: [JSArray] - map: 0x0cfb0018e6b9 <Map[16](PACKED_SMI_ELEMENTS)> [FastProperties] - prototype: 0x0cfb0018e92d <JSArray[0]> - elements: 0x0cfb0004ab6d <FixedArray[17]> [PACKED_SMI_ELEMENTS] - length: 10 - properties: 0x0cfb000006cd <FixedArray[0]> - All own properties (excluding elements): { 0xcfb00000d41: [String] in ReadOnlySpace: #length: 0x0cfb0028741d <AccessorInfo name= 0x0cfb00000d41 <String[6]: #length>, data= 0x0cfb00000061 <undefined>> (const accessor descriptor), location: descriptor } - elements: 0x0cfb0004ab6d <FixedArray[17]> { 0: 0 1: 1 2: 2 3: 3 4: 4 5: 5 6: 6 7: 7 8: 8 9: 9 10-16: 0x0cfb000006e9 <the_hole_value> } 0xcfb0018e6b9: [Map] in OldSpace - map: 0x0cfb00183c35 <MetaMap (0x0cfb00183c85 <NativeContext[285]>)> - type: JS_ARRAY_TYPE - instance size: 16 - inobject properties: 0 - unused property fields: 0 - elements kind: PACKED_SMI_ELEMENTS - enum length: invalid - back pointer: 0x0cfb00000061 <undefined> - prototype_validity cell: 0x0cfb00000a31 <Cell value= 1> - instance descriptors #1: 0x0cfb0018ef45 <DescriptorArray[1]> - transitions #1: 0x0cfb0018ef61 <TransitionArray[4]>Transition array #1: 0x0cfb00000e05 <Symbol: (elements_transition_symbol)>: (transition to HOLEY_SMI_ELEMENTS) -> 0x0cfb0018ef79 <Map[16](HOLEY_SMI_ELEMENTS)> - prototype: 0x0cfb0018e92d <JSArray[0]> - constructor: 0x0cfb0018e625 <JSFunction Array (sfi = 0xcfb0028c6ad)> - dependent code: 0x0cfb000006dd <Other heap object (WEAK_ARRAY_LIST_TYPE)> - construction counter: 0 Compiler returned: 0

Use lookup tables for common functions on node kinds.

9dc225a

typescript-bot assigned DanielRosenwasser Sep 13, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 13, 2024

Sure let's do more

ca2baf4

jakebailey reviewed Sep 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use lookup tables for common functions on node kinds. #59954

Use lookup tables for common functions on node kinds. #59954

DanielRosenwasser commented Sep 13, 2024

DanielRosenwasser commented Sep 13, 2024

typescript-bot commented Sep 13, 2024 •

edited

Loading

typescript-bot commented Sep 13, 2024

tsc

tsserver

startup

DanielRosenwasser commented Sep 13, 2024

typescript-bot commented Sep 13, 2024 •

edited

Loading

typescript-bot commented Sep 13, 2024

tsc

tsserver

startup

jakebailey Sep 13, 2024

DanielRosenwasser Sep 13, 2024

Use lookup tables for common functions on node kinds. #59954

Are you sure you want to change the base?

Use lookup tables for common functions on node kinds. #59954

Conversation

DanielRosenwasser commented Sep 13, 2024

DanielRosenwasser commented Sep 13, 2024

typescript-bot commented Sep 13, 2024 • edited Loading

typescript-bot commented Sep 13, 2024

tsc

tsserver

startup

DanielRosenwasser commented Sep 13, 2024

typescript-bot commented Sep 13, 2024 • edited Loading

typescript-bot commented Sep 13, 2024

tsc

tsserver

startup

jakebailey Sep 13, 2024

Choose a reason for hiding this comment

DanielRosenwasser Sep 13, 2024

Choose a reason for hiding this comment

typescript-bot commented Sep 13, 2024 •

edited

Loading

typescript-bot commented Sep 13, 2024 •

edited

Loading