Fix inconsistent generic indexed access #59415

ahejlsberg · 2024-07-24T22:19:29Z

Fixes the issue reported here. Rationale for fix in comment here.

ahejlsberg · 2024-07-24T22:25:04Z

typescript-bot · 2024-07-24T22:25:08Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-07-24T22:43:49Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-07-24T22:43:53Z

@ahejlsberg Here are the results of running the user tests with tsc comparing main and refs/pull/59415/merge:

Everything looks good!

typescript-bot · 2024-07-24T23:01:31Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,432k (± 0.94%)}	_{193,444k (± 0.97%)}	_~	_192,202k	_195,880k	_{p=1.000 n=6}
_{Parse Time}	_{1.95s (± 0.53%)}	_{1.95s (± 0.32%)}	_~	_1.94s	_1.96s	_{p=0.443 n=6}
_{Bind Time}	_{1.05s (± 1.27%)}	_{1.06s (± 1.14%)}	_~	_1.05s	_1.08s	_{p=0.101 n=6}
_{Check Time}	_{13.97s (± 0.47%)}	_{14.03s (± 0.60%)}	_~	_13.93s	_14.18s	_{p=0.261 n=6}
_{Emit Time}	_{4.05s (± 0.58%)}	_{4.02s (± 0.67%)}	_~	_3.99s	_4.06s	_{p=0.106 n=6}
_{Total Time}	_{21.02s (± 0.25%)}	_{21.06s (± 0.42%)}	_~	_20.95s	_21.20s	_{p=0.520 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_945,532	_945,532	_~	_~	_~	_{p=1.000 n=6}
_Types	_409,507	_409,507	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,221,095k (± 0.00%)}	_{1,221,117k (± 0.01%)}	_~	_1,221,022k	_1,221,197k	_{p=0.378 n=6}
_{Parse Time}	_{7.87s (± 0.65%)}	_{7.89s (± 0.65%)}	_~	_7.82s	_7.96s	_{p=0.629 n=6}
_{Bind Time}	_{2.19s (± 0.38%)}	_{2.21s (± 1.27%)}	_~	_2.19s	_2.27s	_{p=0.065 n=6}
_{Check Time}	_{36.31s (± 0.45%)}	_{36.27s (± 0.34%)}	_~	_36.14s	_36.42s	_{p=0.575 n=6}
_{Emit Time}	_{17.79s (± 0.93%)}	_{17.73s (± 0.48%)}	_~	_17.64s	_17.87s	_{p=0.873 n=6}
_{Total Time}	_{64.16s (± 0.34%)}	_{64.11s (± 0.20%)}	_~	_63.94s	_64.30s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,324,872	_2,324,872	_~	_~	_~	_{p=1.000 n=6}
_Types	_949,556	_949,556	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,222,598k (± 0.00%)}	_{2,222,617k (± 0.00%)}	_~	_2,222,523k	_2,222,711k	_{p=0.689 n=6}
_{Parse Time}	_{6.63s (± 0.49%)}	_{6.65s (± 0.41%)}	_~	_6.61s	_6.69s	_{p=0.334 n=6}
_{Bind Time}	_{2.33s (± 0.45%)}	_{2.32s (± 0.59%)}	_~	_2.30s	_2.34s	_{p=1.000 n=6}
_{Check Time}	_{73.04s (± 0.34%)}	_{73.18s (± 0.35%)}	_~	_72.87s	_73.44s	_{p=0.471 n=6}
_{Emit Time}	_{0.14s (± 3.77%)}	_{0.14s (± 2.95%)}	_~	_0.13s	_0.14s	_{p=0.595 n=6}
_{Total Time}	_{82.13s (± 0.30%)}	_{82.29s (± 0.30%)}	_~	_81.98s	_82.54s	_{p=0.298 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,120	_1,230,118	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,641	_265,639	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,347,392k (± 0.02%)}	_{2,347,464k (± 0.02%)}	_~	_2,347,024k	_2,347,871k	_{p=0.873 n=6}
_{Parse Time}	_{4.99s (± 0.74%)}	_{5.00s (± 1.13%)}	_~	_4.94s	_5.08s	_{p=0.810 n=6}
_{Bind Time}	_{1.90s (± 0.43%)}	_{1.90s (± 0.27%)}	_~	_1.89s	_1.90s	_{p=0.929 n=6}
_{Check Time}	_{34.68s (± 0.44%)}	_{34.72s (± 0.25%)}	_~	_34.63s	_34.88s	_{p=0.423 n=6}
_{Emit Time}	_{3.28s (± 0.71%)}	_{3.29s (± 0.80%)}	_~	_3.26s	_3.33s	_{p=0.470 n=6}
_{Total Time}	_{44.86s (± 0.37%)}	_{44.93s (± 0.15%)}	_~	_44.88s	_45.06s	_{p=0.575 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,120	_1,230,118	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_265,641	_265,639	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,421,655k (± 0.03%)}	_{2,421,770k (± 0.04%)}	_~	_2,421,147k	_2,423,557k	_{p=0.575 n=6}
_{Parse Time}	_{6.25s (± 0.97%)}	_{6.28s (± 0.45%)}	_~	_6.24s	_6.31s	_{p=0.378 n=6}
_{Bind Time}	_{2.06s (± 1.00%)}	_{2.05s (± 0.84%)}	_~	_2.02s	_2.07s	_{p=0.294 n=6}
_{Check Time}	_{41.39s (± 0.39%)}	_{41.45s (± 0.35%)}	_~	_41.31s	_41.68s	_{p=0.810 n=6}
_{Emit Time}	_{4.07s (± 3.33%)}	_{4.05s (± 1.45%)}	_~	_3.97s	_4.12s	_{p=1.000 n=6}
_{Total Time}	_{53.78s (± 0.36%)}	_{53.83s (± 0.37%)}	_~	_53.60s	_54.14s	_{p=0.873 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,471	_258,469	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,534	_105,532	_{-2 (- 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{429,148k (± 0.04%)}	_{429,030k (± 0.01%)}	_~	_428,997k	_429,068k	_{p=0.092 n=6}
_{Parse Time}	_{3.34s (± 1.23%)}	_{3.36s (± 0.52%)}	_~	_3.33s	_3.37s	_{p=0.361 n=6}
_{Bind Time}	_{1.32s (± 1.70%)}	_{1.33s (± 0.78%)}	_~	_1.32s	_1.35s	_{p=0.558 n=6}
_{Check Time}	_{18.05s (± 0.46%)}	_{18.02s (± 0.41%)}	_~	_17.93s	_18.11s	_{p=0.521 n=6}
_{Emit Time}	_{1.64s (± 2.13%)}	_{1.64s (± 1.63%)}	_~	_1.61s	_1.67s	_{p=0.871 n=6}
_{Total Time}	_{24.36s (± 0.56%)}	_{24.34s (± 0.40%)}	_~	_24.23s	_24.46s	_{p=1.000 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,931	_224,931	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,146	_94,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,025k (± 0.03%)}	_{370,033k (± 0.03%)}	_~	_369,852k	_370,115k	_{p=1.000 n=6}
_{Parse Time}	_{2.75s (± 1.05%)}	_{2.77s (± 0.67%)}	_~	_2.73s	_2.78s	_{p=0.288 n=6}
_{Bind Time}	_{1.58s (± 0.87%)}	_{1.59s (± 1.05%)}	_~	_1.57s	_1.61s	_{p=0.303 n=6}
_{Check Time}	_{15.64s (± 0.13%)}	_{15.65s (± 0.56%)}	_~	_15.53s	_15.79s	_{p=1.000 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.97s (± 0.23%)}	_{20.01s (± 0.46%)}	_~	_19.87s	_20.14s	_{p=0.336 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁₁	₁₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,985,953	_2,985,953	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,027,137	_1,027,137	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,109,965k (± 0.00%)}	_{3,109,957k (± 0.00%)}	_~	_3,109,892k	_3,110,051k	_{p=0.810 n=6}
_{Parse Time}	_{13.81s (± 0.33%)}	_{13.81s (± 0.19%)}	_~	_13.78s	_13.85s	_{p=0.628 n=6}
_{Bind Time}	_{4.29s (± 2.13%)}	_{4.25s (± 0.38%)}	_~	_4.24s	_4.28s	_{p=0.186 n=6}
_{Check Time}	_{78.82s (± 0.14%)}	_{78.80s (± 0.34%)}	_~	_78.41s	_79.09s	_{p=0.936 n=6}
_{Emit Time}	_{20.39s (± 0.52%)}	_{20.44s (± 0.61%)}	_~	_20.28s	_20.61s	_{p=0.469 n=6}
_{Total Time}	_{117.31s (± 0.16%)}	_{117.30s (± 0.14%)}	_~	_117.10s	_117.47s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,560	_267,560	_~	_~	_~	_{p=1.000 n=6}
_Types	_109,076	_109,076	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{412,503k (± 0.01%)}	_{412,422k (± 0.01%)}	_{-81k (- 0.02%)}	_412,373k	_412,481k	_{p=0.020 n=6}
_{Parse Time}	_{4.76s (± 0.68%)}	_{4.75s (± 0.67%)}	_~	_4.70s	_4.80s	_{p=0.570 n=6}
_{Bind Time}	_{2.13s (± 0.65%)}	_{2.11s (± 0.52%)}	_~	_2.10s	_2.13s	_{p=0.066 n=6}
_{Check Time}	_{20.82s (± 0.34%)}	_{20.79s (± 0.31%)}	_~	_20.71s	_20.90s	_{p=0.471 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.71s (± 0.24%)}	_{27.65s (± 0.28%)}	_~	_27.57s	_27.78s	_{p=0.196 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_511,803	_511,803	_~	_~	_~	_{p=1.000 n=6}
_Types	_162,088	_162,088	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{449,248k (± 0.06%)}	_{449,327k (± 0.03%)}	_~	_449,129k	_449,450k	_{p=0.689 n=6}
_{Parse Time}	_{2.61s (± 0.31%)}	_{2.63s (± 0.57%)}	_~	_2.61s	_2.65s	_{p=0.116 n=6}
_{Bind Time}	_{0.97s (± 0.53%)}	_{0.97s (± 1.51%)}	_~	_0.96s	_1.00s	_{p=0.784 n=6}
_{Check Time}	_{14.60s (± 0.37%)}	_{14.57s (± 0.31%)}	_~	_14.51s	_14.63s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{18.18s (± 0.28%)}	_{18.17s (± 0.28%)}	_~	_18.09s	_18.22s	_{p=0.873 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-25T00:07:46Z

@ahejlsberg Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59415/merge:

Everything looks good!

ahejlsberg added 3 commits July 24, 2024 15:16

In obj[key], omit non-nullable check when obj and key are both generic

7cba33c

Add tests

b93a10b

Accept new baselines

b9b07c4

typescript-bot assigned ahejlsberg Jul 24, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 24, 2024

ahejlsberg requested a review from DanielRosenwasser July 25, 2024 01:10

ahejlsberg mentioned this pull request Jul 26, 2024

Fix generic nullable checks #59437

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix inconsistent generic indexed access #59415

Fix inconsistent generic indexed access #59415

ahejlsberg commented Jul 24, 2024 •

edited

Loading

ahejlsberg commented Jul 24, 2024

typescript-bot commented Jul 24, 2024 •

edited

Loading

typescript-bot commented Jul 24, 2024

typescript-bot commented Jul 24, 2024

typescript-bot commented Jul 24, 2024

tsc

typescript-bot commented Jul 25, 2024

Fix inconsistent generic indexed access #59415

Are you sure you want to change the base?

Fix inconsistent generic indexed access #59415

Conversation

ahejlsberg commented Jul 24, 2024 • edited Loading

ahejlsberg commented Jul 24, 2024

typescript-bot commented Jul 24, 2024 • edited Loading

typescript-bot commented Jul 24, 2024

typescript-bot commented Jul 24, 2024

typescript-bot commented Jul 24, 2024

tsc

typescript-bot commented Jul 25, 2024

ahejlsberg commented Jul 24, 2024 •

edited

Loading

typescript-bot commented Jul 24, 2024 •

edited

Loading