Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support for userCol and itemCol as string types in SAR model #2283

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

feat: Support for userCol and itemCol as string types in SAR model #2283

wants to merge 12 commits into from

Commits on Sep 7, 2024

  1. feat: add string to sar

    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    d580344 View commit details
    Browse the repository at this point in the history

  2. Delete core/src/main/python/synapse/ml/recommendation/SAR.py

    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    302fb7c View commit details
    Browse the repository at this point in the history

  3. Update core/src/main/scala/com/microsoft/azure/synapse/ml/recommendat… 

    …ion/SARModel.scala
    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    8418cc0 View commit details
    Browse the repository at this point in the history

  4. Update core/src/main/scala/com/microsoft/azure/synapse/ml/recommendat… 

    …ion/SAR.scala
    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    f84e051 View commit details
    Browse the repository at this point in the history

  5. Update SARSpec.scala

    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    a38b134 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review

    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    129081d View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review

    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    fc8a97f View commit details
    Browse the repository at this point in the history

  8. Update docs/Quick Examples/estimators/core/_Recommendation.md

    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    92685b8 View commit details
    Browse the repository at this point in the history

  9. Apply suggestions from code review

    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    dbade6e View commit details
    Browse the repository at this point in the history

  10. Update SAR.scala to handle integer types for userId and itemId 

    * **SAR.scala**
  - Update `calculateUserItemAffinities` method to handle integer types for `userId` and `itemId`
  - Update `calculateItemItemSimilarity` method to handle integer types for `userId` and `itemId`

* **test_ranking.py**
  - Add test cases to verify the functionality of SAR model with integer types for `userId` and `itemId`
    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    09557ea View commit details
    Browse the repository at this point in the history

  11. Discard changes to core/src/test/scala/com/microsoft/azure/synapse/ml… 

    …/recommendation/SARSpec.scala
    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    11dae03 View commit details
    Browse the repository at this point in the history

  12. Add new test cases for User Column with Strings and other datatypes i… 

    …n SARSpec.scala

* Add a test case for handling User Column with Strings
* Add a test case for handling User Column with different datatypes
* Verify the handling of User Column with Strings and other datatypes in SAR.scala
* Ensure the new test cases are concise and focused on the new code
* Place the new test cases in an appropriate location within the file
    @dciborow
    dciborow committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    9981bee View commit details
    Browse the repository at this point in the history