Initially use [[msvc::no_unique_address]] for some C++23 components
#4960
+262
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `in_value_result` - `out_value_result` - `mdspan` - `join_with_view`'s sentinel - `enumerate_view`'s iterator and sentinel - `chunk_view`'s iterator - `slide_view`'s sentinel
This comment was marked as resolved.
This comment was marked as resolved.
CaseyCarter
added
performance
|
I'm going to mark this "decision needed" so we can discuss it in the maintainer meeting this week. We need to decide how we're going to communicate to Nvidia and Intel that this is going to happen and that they'll need to implement this part of the ABI to travel into the future with us. |
StephanTLavavej
removed
the
decision needed
|
I've communicated this upcoming change to our contacts at NVIDIA. As CUDA 12.4.0 doesn't support C++23, you can revert your experimental test change here. We don't officially support Intel's compiler, but as it's Clang-based we expect that it won't have problems understanding this attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #1364.
Applied:
in_value_resultout_value_resultmdspanjoin_with_view's sentinelenumerate_view's iterator and sentinelchunk_view's iteratorslide_view's sentinelNot yet applied due to DevCom-10588147 and possibly related issues.
view_interfaceas their empty bases.iterator_category.chunk_by_view's iterator, possibly because the non-potentially-overlapping member is listed first.Not yet applied because it's unclear to me how to reuse padding bytes in
tuplezip-familyNot yet applied due to another unclear reasons
expectedOther changes:
/* [[no_unique_address]] */for_Index_typeofrepeat_view's iterator because the_Index_typenever has padding bytes<mdspan>: More EBO #3847 to a separated test fileattempt to test NVCC for these changesfailed and reverted.