P2502R2 <generator>: Synchronous Coroutine Generator For Ranges
#4953
+1,723
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge `main` to `feature/generator`
Resolved conflict in yvals_core.h, removing all guards around `__cpp_lib_generator` except `_HAS_CXX23`. * `__cpp_lib_concepts` is now always available in C++20 and later. * `<generator>` doesn't care about `std::byte` now. * C1XX, Clang, and EDG all define `__cpp_impl_coroutine` in C++20 and later, which wasn't the case earlier.
Also add a missing semicolon - this emits a `_Pragma`.
VSO-1951821 "EDG instantiates the wrong overload of `promise_type::operator new` for `generator` machinery"
Merge `main` to `feature/generator`
Merge `main` to `feature/generator`
Merge `main` to `feature/generator`
Co-authored-by: Stephan T. Lavavej <[email protected]>
Resolved a trivial merge conflict in `<ranges>` with the `inline constexpr` change for `_Compile_time_max_size`.
Merge `main` to `feature/generator`
Co-authored-by: Casey Carter <[email protected]>
Merge `main` to `feature/generator`
Co-authored-by: Stephan T. Lavavej <[email protected]> Co-authored-by: Alex Guteniev <[email protected]>
…ource>` after GH 4952.
This comment was marked as resolved.
This comment was marked as resolved.
* `const`-ify members of awaitable objects that can be `const`. * Annotate that the iterator's `operator*` has a `/* strengthened */` _noexcept-specifier_.
StephanTLavavej
requested changes
Sep 17, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Several minor nits, and I burned away all the unnecessary parts of "mutable rvalue reference type". Don't know where I was heading with it, but it never made it there.
StephanTLavavej
approved these changes
Sep 18, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
I had to push an additional commit to work around VSO-2254804 "EDG ICE in |
I suspect this is related to the confusion about coroutines and x86 MSABI discussed in LLVM-59382. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 44 commits from
feature/generatorplus one more to add aforwardin atest_oneoverload inP2502R2_generator.I've verified that we implement the resolutions of the three LWG issues mentioned in #2936, and recently validated that we address all the "add a new header requirements".
Closes #2936, fixes #4952 (comment).
I stuffed all the implementation details in
<generator>intonamespace _Gen_detail, and simplified names that no longer need disambiguation. The delta looks huge, but the largest commit (b61b7ba) is mostly just additional indentation, and the remainder are a single rename each.