Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize pointer in basic_string::_Allocate_for_capacity #4474

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

tiagomacarios
Copy link
Member

@tiagomacarios tiagomacarios commented Mar 13, 2024

... to silence -d1initall's complaint.

Fixes #4473

@tiagomacarios tiagomacarios requested a review from a team as a code owner March 13, 2024 00:14
@CaseyCarter CaseyCarter changed the title Fix 4473 Initialize pointer in _Allocate_for_capacity Mar 13, 2024
@StephanTLavavej StephanTLavavej added the bug Something isn't working label Mar 13, 2024
@StephanTLavavej StephanTLavavej changed the title Initialize pointer in _Allocate_for_capacity Initialize pointer in basic_string::_Allocate_for_capacity Mar 13, 2024
@StephanTLavavej StephanTLavavej self-assigned this Mar 15, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 64d9a59 into microsoft:main Mar 16, 2024
37 checks passed
@StephanTLavavej
Copy link
Member

Thanks for fixing this undocumented compiler option! 🤫 📜 ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

<xstring>: constexpr string does not compile with -d1initall
3 participants