<format>: Always enable compile-time format string checking for wchar_t
#4459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
approved these changes
Mar 13, 2024
barcharcraz
reviewed
Mar 14, 2024
| @@ -3682,7 +3682,7 @@ public: | |||
| template <class _Ty> | |||
| requires convertible_to<const _Ty&, basic_string_view<_CharT>> | |||
| consteval basic_format_string(const _Ty& _Str_val) : _Str(_Str_val) { | |||
| if (_Is_execution_charset_self_synchronizing()) { | |||
| if constexpr (!is_same_v<_CharT, char> || _Is_execution_charset_self_synchronizing()) { | |||
There was a problem hiding this comment.
why not is_same_v<_CharT, wchar_t>? That seems more direct to me.
There was a problem hiding this comment.
My opinion was that !is_same_v<_CharT, char> would "automatically" support charN_t if formatting for them gets supported in the future.
(or is not
char, if formatting forcharN_tis supported in the future)
But this reason may be not strong enough.
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
format(L"Thanks!!! {}", L"😻✅") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been enabling compiler-time format string checking for self-synchronizing execution character sets (see #2221 and #2493).
However, when the character type is
wchar_t, the checking may also be skipped for certain execution character sets (Godbolt link), although, IIUC, the supported execution wide character set should always be Unicode and MSVC STL only supportswchar_tof the UTF-16 encoding.This PR unconditionally enables compiler-time format string checking when the character type is
wchar_t(or is notchar, if formatting forcharN_tis supported in the future).