Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status Chart: Remove videos, hide bugs/issues by default #4235

Merged
merged 10 commits into from
Dec 5, 2023

Conversation

StephanTLavavej
Copy link
Member

As discussed in the weekly maintainers meeting, this removes the video line that was added in #3129. The code review videos were very useful, but we simply haven't had time to record or especially transcribe them for uploading, nor will we for the foreseeable future. I looked at the original diff and manually (not mechanically) reverted the changes.

Also as discussed, this hides the bugs and issues lines by default, to reduce visual noise. This is definitely interesting data, but it's not a metric that we're constantly obsessed with.

In the readme, I noticed that there was an outdated mention of es-module-shims (after #3645), which I've dropped.

As usual there are weekly updates and minor dependency updates, including a new minor version of chart.js (no display changes AFAICT; I load the old and new charts into different tabs and switch between them with Ctrl+2 and Ctrl+3 for example to see if glitches have appeared).

Because this contains coordinated changes between the JS/TS and HTML, there's a "REGEN BEFORE MERGING" commit that will accumulate merge conflicts.

📉 Live preview: stephantlavavej.github.io/STL/

@StephanTLavavej StephanTLavavej added the documentation Related to documentation or comments label Dec 4, 2023
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner December 4, 2023 20:59
@StephanTLavavej StephanTLavavej merged commit 123a45d into microsoft:gh-pages Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to documentation or comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants