Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analyzers] Resolve StyleCop issues: SA1516 and SA1616 #34853

Merged
merged 26 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
e450163
[Analyzers][AdvancedPaste] Apply fix for SA1516
snickler Sep 12, 2024
d58f54e
[Analyzers][EnvironmentVariables] Apply fix for SA1516
snickler Sep 12, 2024
18694ac
[Analyzers][RegistryPreview] Apply fix for SA1516
snickler Sep 12, 2024
5da4e34
[Analyzers][Peek] Apply fix for SA1516
snickler Sep 12, 2024
5703911
[Analyzers][PreviewPane] Apply fix for SA1516
snickler Sep 12, 2024
a77ef77
[Analyzers][FancyZones] Apply fix for SA1516
snickler Sep 12, 2024
c2b4110
[Analyzers][PT Run][Plugins] Apply fix for SA1516
snickler Sep 12, 2024
8211f0d
[Analyzers][PT Run] Apply fix for SA1516
snickler Sep 12, 2024
7eab84f
[Analyzers][PT Run][Wox] Apply fix for SA1516
snickler Sep 12, 2024
0992d15
[Analyzers][Common] Apply fix for SA1516
snickler Sep 12, 2024
7d5e847
[Analyzers][ImageResizer] Apply fix for SA1516
snickler Sep 12, 2024
ae171e4
[Analyzers][ColorPicker] Apply fix for SA1516
snickler Sep 12, 2024
6f0edb6
[Analyzers][MouseUtils] Apply fix for SA1516
snickler Sep 12, 2024
15b3f5e
[Analyzers][DSC Schema Generator] Apply fix for SA1516
snickler Sep 12, 2024
e903aab
[Analyzers][FileLocksmith] Apply fix for SA1516
snickler Sep 12, 2024
f85c898
[Analyzers][Hosts] Apply fix for SA1516
snickler Sep 12, 2024
8decad0
[Analyzers][MeasureTool] Apply fix for SA1516
snickler Sep 12, 2024
e69ddce
[Analyzers][MouseWithoutBorders] Apply fix for SA1516
snickler Sep 12, 2024
2aaaf3e
[Analyzers][TextExtractor] Apply fix for SA1516
snickler Sep 12, 2024
cb371a4
[Analyzers][Workspaces] Apply fix for SA1516
snickler Sep 12, 2024
de8cf69
[Analyzers][Awake] Apply fix for SA1516
snickler Sep 12, 2024
254b95a
[Analyzers][PowerAccent] Apply fix for SA1516
snickler Sep 12, 2024
c8b6ad6
[Analyzers][RegistryPreview] Apply fix for SA1516
snickler Sep 12, 2024
2dc40c4
[Analyzers][Settings] Apply fix for SA1516
snickler Sep 12, 2024
c3110d6
[Analyzers][MouseWithoutBorders] Apply fix for SA1616
snickler Sep 12, 2024
0a9d9ef
Fix extra file in PR
jaimecbernardo Sep 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions src/common/AllExperiments/Experiments.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System.Globalization;
using System.Text.Json;

using Microsoft.PowerToys.Settings.UI.Library.Telemetry.Events;
using Microsoft.PowerToys.Telemetry;
using Microsoft.VariantAssignment.Client;
Expand Down
1 change: 1 addition & 0 deletions src/common/Common.UI/ThemeManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System;
using System.Linq;
using System.Windows;

using ManagedCommon;
using Microsoft.Win32;

Expand Down
1 change: 1 addition & 0 deletions src/common/FilePreviewCommon/MarkdownHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.IO;

using Markdig;

namespace Microsoft.PowerToys.FilePreviewCommon
Expand Down
1 change: 1 addition & 0 deletions src/common/FilePreviewCommon/MonacoHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using System.IO;
using System.Reflection;
using System.Text.Json;

using Microsoft.PowerToys.FilePreviewCommon.Monaco.Formatters;

namespace Microsoft.PowerToys.FilePreviewCommon
Expand Down
1 change: 1 addition & 0 deletions src/common/ManagedCommon/Logger.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using System.Globalization;
using System.IO.Abstractions;
using System.Reflection;

using PowerToys.Interop;

namespace ManagedCommon
Expand Down
1 change: 1 addition & 0 deletions src/common/ManagedCommon/RunnerHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Diagnostics;
using System.Reflection;
using System.Threading.Tasks;

using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;

Expand Down
1 change: 1 addition & 0 deletions src/common/ManagedCommon/ThemeHelpers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.Runtime.InteropServices;

using Microsoft.Win32;

namespace ManagedCommon
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using Microsoft.PowerToys.Telemetry.Events;

namespace Microsoft.PowerToys.Telemetry
Expand Down
1 change: 1 addition & 0 deletions src/common/interop/interop-tests/InteropTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.Threading;

using Microsoft.VisualStudio.TestTools.UnitTesting;
using PowerToys.Interop;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Collections.Generic;
using System.Globalization;
using System.Linq;

using static PowerToys.Settings.DSC.Schema.Introspection;

namespace PowerToys.Settings.DSC.Schema;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.Linq;

using static PowerToys.Settings.DSC.Schema.Introspection;

namespace PowerToys.Settings.DSC.Schema;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Linq;
using System.Reflection;
using System.Text.Json.Serialization;

using Settings.UI.Library.Attributes;

namespace PowerToys.Settings.DSC.Schema;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System;
using System.Globalization;
using System.Linq;

using static PowerToys.Settings.DSC.Schema.Introspection;

namespace PowerToys.Settings.DSC.Schema;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using System.Linq;
using System.Threading;
using System.Threading.Tasks;

using AdvancedPaste.Helpers;
using AdvancedPaste.Settings;
using AdvancedPaste.ViewModels;
Expand All @@ -17,7 +18,9 @@
using Microsoft.UI.Xaml;
using Windows.Graphics;
using WinUIEx;

using static AdvancedPaste.Helpers.NativeMethods;

using DispatcherQueue = Microsoft.UI.Dispatching.DispatcherQueue;

// To learn more about WinUI, the WinUI project structure,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.Numerics;

using Microsoft.UI.Composition;
using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Media;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System;
using System.Net;
using System.Threading.Tasks;

using AdvancedPaste.Helpers;
using AdvancedPaste.Settings;
using AdvancedPaste.ViewModels;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.Collections;

using Microsoft.UI.Xaml.Data;

namespace AdvancedPaste.Converters;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.Collections;

using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Data;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System;

using AdvancedPaste.Helpers;
using AdvancedPaste.Settings;
using ManagedCommon;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using System.Collections.ObjectModel;
using System.Linq;
using System.Threading.Tasks;

using AdvancedPaste.Helpers;
using AdvancedPaste.Models;
using AdvancedPaste.ViewModels;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Globalization;
using System.IO;
using System.Net;

using Azure;
using Azure.AI.OpenAI;
using ManagedCommon;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System;
using System.Threading;
using System.Threading.Tasks;

using ManagedCommon;
using Microsoft.UI.Xaml.Media.Imaging;
using Windows.ApplicationModel.DataTransfer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Collections.ObjectModel;

using Microsoft.PowerToys.Settings.UI.Library;

namespace AdvancedPaste.Settings
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using System.Text.RegularExpressions;
using System.Threading.Tasks;
using System.Xml;

using ManagedCommon;
using Newtonsoft.Json;
using Windows.ApplicationModel.DataTransfer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
using System.Linq;
using System.Text.RegularExpressions;
using System.Threading.Tasks;

using HtmlAgilityPack;
using ManagedCommon;
using Windows.ApplicationModel.DataTransfer;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using System.IO.Abstractions;
using System.Threading;
using System.Threading.Tasks;

using ManagedCommon;
using Microsoft.PowerToys.Settings.UI.Library;
using Microsoft.PowerToys.Settings.UI.Library.Utilities;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Text.Json;

using AdvancedPaste.Helpers;
using Microsoft.PowerToys.Settings.UI.Library.Interfaces;

Expand Down
1 change: 1 addition & 0 deletions src/modules/AdvancedPaste/AdvancedPaste/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.Threading;

using ManagedCommon;
using Microsoft.UI.Dispatching;
using Microsoft.Windows.AppLifecycle;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using AdvancedPaste.Models;
using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using AdvancedPaste.Models;
using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using System.Linq;
using System.Net;
using System.Threading.Tasks;

using AdvancedPaste.Helpers;
using AdvancedPaste.Models;
using AdvancedPaste.Settings;
Expand All @@ -22,6 +23,7 @@
using Windows.ApplicationModel.DataTransfer;
using Windows.System;
using WinUIEx;

using DispatcherQueue = Microsoft.UI.Dispatching.DispatcherQueue;

namespace AdvancedPaste.ViewModels
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.IO.Abstractions;

using EnvironmentVariables.Telemetry;
using EnvironmentVariablesUILib;
using EnvironmentVariablesUILib.Helpers;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.Runtime.InteropServices;

using EnvironmentVariables.Win32;
using EnvironmentVariablesUILib;
using EnvironmentVariablesUILib.Helpers;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System;

using EnvironmentVariablesUILib.Helpers;
using ManagedCommon;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

using System;
using System.Threading;

using ManagedCommon;
using Microsoft.UI.Dispatching;
using Microsoft.Windows.AppLifecycle;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System.Diagnostics.Tracing;

using EnvironmentVariablesUILib.Models;
using Microsoft.PowerToys.Telemetry;
using Microsoft.PowerToys.Telemetry.Events;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System;

using EnvironmentVariablesUILib.Models;
using Microsoft.UI.Xaml.Data;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System;

using EnvironmentVariablesUILib.Helpers;
using EnvironmentVariablesUILib.Models;
using Microsoft.UI.Xaml.Data;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System;

using EnvironmentVariablesUILib.Helpers;
using EnvironmentVariablesUILib.Models;
using Microsoft.UI.Xaml.Data;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// See the LICENSE file in the project root for more information.

using System;

using EnvironmentVariablesUILib.Models;
using Microsoft.UI.Xaml;
using Microsoft.UI.Xaml.Data;
Expand Down
Loading
Loading