Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EnvVar] Treat well-known debugging environment variables as lists #34689

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[EnvVar] Treat well-known debugging environment variables as lists #34689

wants to merge 2 commits into from
+10 −1

Conversation

chwarr
Copy link
Member

@chwarr chwarr commented Sep 7, 2024

Summary of the Pull Request

Treat the following additional environment variables as lists, like the "PATH" variable:

  • _NT_SYMBOL_PATH
  • _NT_ALT_SYMBOL_PATH
  • _NT_SYMCACHE_PATH

PR Checklist

  • Closes: Treat well-known debugging environment variables as lists #34661
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: N/A, as there are no existing automated tests for this feature
  • Localization: N/A, as there are no user-visible strings
  • Dev docs: N/A
  • New binaries: N/A
  • Documentation updated: N/A, as this behavior is not documented today.

Detailed Description of the Pull Request / Additional comments

Windows Debugger paths are documented as being semi-colon delimited. The _NT_SYMCACHE_PATH is used by WPA, and it also documented as being semi-colon delimited.

Validation Steps Performed

  1. Manually validated that _NT_SYMBOL_PATH, _NT_ALT_SYMBOL_PATH, and _NT_SYMCACHE_PATH use the list editing UX.
  2. Manually validated that PATH and PATHEXT continue to use the list editing UX.

@chwarr
[EnvVar] Treat well-known debugging environment variables as lists
e6444a7 
The following environment variables are semi-colon lists, like "PATH"

* _NT_SYMBOL_PATH
* _NT_ALT_SYMBOL_PATH
* _NT_SYMCACHE_PATH

Treat them as lists in the Environment Variable editor.

Windows Debugger paths are [documented as being semi-colon
delimited][0]. The [`_NT_SYMCACHE_PATH` is used by WPA][1], and it also
documented as being semi-colon delimited.

[0]: https://learn.microsoft.com/en-us/windows/win32/debug/symbol-paths
[1]: https://learn.microsoft.com/en-us/windows-hardware/test/wpt/loading-symbols
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@chwarr chwarr marked this pull request as draft September 13, 2024 20:31
@chwarr chwarr marked this pull request as ready for review September 13, 2024 20:31
@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
5. Needs Attention
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chwarr @crutkas