Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added word wrapping for the syntax help window description text #34424

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Agnibaan
Copy link
Contributor

@Agnibaan Agnibaan commented Aug 24, 2024

The syntax help window of powerRename has text cut off issue so i added the text wrap in the textblock.

@Agnibaan
Copy link
Contributor Author

@htcfreek hey u can check this one ...

@stefansjfw
Copy link
Collaborator

stefansjfw commented Aug 25, 2024

@Agnibaan can you attach before and after screenshots of what this change fixes? Thanks

Copy link
Collaborator

@htcfreek htcfreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not work as expected.

  1. There are three different list views. One per syntax type (Date, Counter, ...). So you need to set text wrapping property in each list view.
  2. The text can't not wrap because the description grid column of the list views is to wide and exceeds the flyout wide.

image

@htcfreek
Copy link
Collaborator

@Agnibaan can you attach before and after screenshots of what this change fixes? Thanks

@stefansjfw
This is how it currently looks:
image

And this is what we try to get:
image
(This screenshot was made with a fixed grid wide for testing.)

But while debugging I saw that there is a vertical scrollbar on the bottom of the flyout. Not sure if we should add wrapping realy. But I think with wrapping it looks better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants