Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monaco] Make minimap toggleable #33742

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

PesBandi
Copy link
Contributor

@PesBandi PesBandi commented Jul 9, 2024

Summary of the Pull Request

Adds the option to toggle the minimap for file preview (Peek and Preview Pane)

PR Checklist

  • Closes: [FilePreview] Add option to toggle minimap #33471
  • Communication: I've discussed this with core contributors already.
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: No need
  • New binaries: None
  • Documentation updated: No need

Detailed Description of the Pull Request / Additional comments

Adds a setting to Peek and File Explorer add-ons to toggle the Monaco minimap. Disabled by default. Also adds a context menu item to Monaco to toggle the minimap.

Validation Steps Performed

Testing Peek and Preview Pane

@crutkas
Copy link
Member

crutkas commented Jul 10, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@htcfreek
Copy link
Collaborator

@PesBandi
Please merge main in, fix the conflicts and update your code changes.

@PesBandi
Copy link
Contributor Author

@PesBandi Please merge main in, fix the conflicts and update your code changes.

Hello @htcfreek thank you for notifying me, it's fixed now. Could you please take a look? Thanks

@PesBandi PesBandi marked this pull request as draft August 8, 2024 06:19
@PesBandi PesBandi marked this pull request as ready for review August 23, 2024 20:49
@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants