Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Run] Add path existence check for windows+wsl env #30821

Merged

Conversation

anderspk
Copy link
Contributor

@anderspk anderspk commented Jan 8, 2024

Summary of the Pull Request

Added filter to remove stale workspaces search results.

PR Checklist

Detailed Description of the Pull Request / Additional comments

I only added handling for local and WSL workspace environments, as I was unsure how to check the other cases properly.

Validation Steps Performed

Tested locally.

@anderspk
Copy link
Contributor Author

anderspk commented Jan 8, 2024

@microsoft-github-policy-service agree

@anderspk anderspk marked this pull request as ready for review January 9, 2024 11:20
@anderspk anderspk changed the title Add path existence check for windows+wsl env [Run] Add path existence check for windows+wsl env Jan 9, 2024
@anderspk anderspk force-pushed the run-filter-nonexistent-workspaces branch from c5402f7 to 96ede78 Compare January 14, 2024 23:18
@anderspk
Copy link
Contributor Author

Sorry, if anyone checked this branch out earlier, I somehow managed to push an older version that wasn't working properly. This is now fixed 😅

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Checked and didn't break anything to me, so I think it should be fine.
Thank you for the contribution.

@jaimecbernardo jaimecbernardo merged commit 52e9199 into microsoft:main Jan 17, 2024
9 checks passed
@anderspk anderspk deleted the run-filter-nonexistent-workspaces branch January 17, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants