Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Peek] Add support for preview handlers #28690

Merged

Conversation

dillydylann
Copy link
Contributor

@dillydylann dillydylann commented Sep 21, 2023

Summary of the Pull Request

This PR adds support for preview handlers that displays previews from supported applications like Microsoft Office (assuming the user has it installed).

This should also help with:

PR Checklist

Detailed Description of the Pull Request / Additional comments

Word

image

Excel

image

PowerPoint

image

Visio

image

Fonts

image

@github-actions

This comment has been minimized.

@stefansjfw stefansjfw self-requested a review September 21, 2023 21:43
@crutkas
Copy link
Member

crutkas commented Sep 21, 2023

🔥🔥🔥 O_O 🔥🔥🔥

@dillydylann dillydylann marked this pull request as ready for review September 26, 2023 20:21
@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Oct 6, 2023
@jaimecbernardo jaimecbernardo self-requested a review October 9, 2023 16:09
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This is a great contribution! Thank you so much!

LGTM, too. I'm a bit skeptical of the unsafe use too, but it makes sense here and the code doesn't look bad intentioned.

We've won gcode from our file previewers from this as well.
I love that it's used as a previewer only if Peek doesn't support that file with the other previewers already.
Tested on a computer that has office installed and this is previewing Office files as well, so I'm guessing we can "check" those as well.

Great contribution, once again! 😄

@jaimecbernardo jaimecbernardo merged commit e1944df into microsoft:main Oct 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants