[Peek] Support for archives

[davidegiacometti]

Summary of the Pull Request

Support for archives preview in peek: .zip, .rar, .7z, .tar, .nupkg, .jar, .gz, .tar, .tar.gz, .tgz

A month ago I was working on an explorer preview pane for archives (branch).
Chatted with @crutkas about the new preview pane and the WinUI3 startup was a concern.
I am shifting the job into peek based on #26726.
If preview panes will stay in PT we may reconsider adding also the preview pane (it would be nice to share logic with peek if possible).

Still a WIP but early feedbacks will be appreciated ☺️

PR Checklist

• Closes: [Peek] Support for archives #26855
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[htcfreek]

If possible, supporting iso, cab would be amazing.

And we should have scroll bars in both directions on small window size. - Not sure if this is by default.

[htcfreek]

@davidegiacometti
Can you please check the open issues to reference an existing one or create a new one.

[davidegiacometti]

@htcfreek
I have created #26855
I have added horizontal scrolling.
Unfortunately the library doesn't support .cab and .iso. This could be a future enhancement if we find a way to enumerate the content of these formats (a library would be nice).

[crutkas]

🔥🔥🔥

[htcfreek]

@davidegiacometti
There is a long time outstanding issue for .iso format on the SharpCompress repository. (adamhathcock/sharpcompress/issues/545, adamhathcock/sharpcompress/issues/647)

Iread somewhere that there is a DiskUtils library that supports .iso. But I don't know if we can use it in this case and I am not sure if it is actively maintained.

For .cab I created an issue in the SharpCompress repository. (adamhathcock/sharpcompress/issues/747)

[davidegiacometti]

I am having hard times to investigate an issue with the TreeView that is leaking memory.
The issue may be related to WinUI but I can't fully understand the lifecycle of the IPreviewer: some of them implement IDisposable but are always reassigned and never disposed.

PowerToys/src/modules/peek/Peek.FilePreviewer/FilePreview.xaml.cs

Line 152 in c7f8b69

Previewer = previewerFactory.Create(Item);

It would be nice if the someone of the core team could help.

[SamChaps]

This looks awesome! Could be consider supporting previewing files from within that ArchiveControl?

[davidegiacometti]

This looks awesome! Could be consider supporting previewing files from within that ArchiveControl?

Thank you!

Do you mean to move the code that open the archive, create the treeview, sizes and counters inside the user control?
Could make sense but based on the other implemented IPreviewer this job should be done in the LoadPreviewAsync method.
What do you think?

[SamChaps]

@davidegiacometti no, what I mean is to be able to Ctrl+Space within that control and allow preview of each single archived file.

[davidegiacometti]

Oh! My bad 😅I totally misunderstood your feedback 😄
I think this will require to extract the file from the archive and somehow switch between previewers. I will create an issue to track this.

[stefansjfw]

The code looks good to me. It works flawlessly as well. Very nice! I see the mentioned memory leak, as far as I understood this is probably TreeView issue. Something to track for sure. It would be good if @SeraphimaZykova and @SamChaps could take another look before merging

[SeraphimaZykova]

I've noticed that there is no NativeMethods.DeleteObject after getting icons. Take a look at ImagePreviewer (Clear method), I've fixed the mem leak that way there. Perhaps it could help.

[SeraphimaZykova]

Overall, nice work! :)

[stefansjfw]

I've noticed that there is no NativeMethods.DeleteObject after getting icons. Take a look at ImagePreviewer (Clear method), I've fixed the mem leak that way there. Perhaps it could help.

There is DestroyIcon call in GetBitmapFromHIconAsync

[crutkas]

This ready for .71?

[stefansjfw]

This ready for .71?

yes, almost there. Just a bit of some more reviewing left

[davidegiacometti]

Yeah, the DestroyIcon is called inside the helper to align the behavior with the existing method.

I have pushed a minor cleanup that removes a redundant helper for file size since Peek already had one b112b71 😇

[davidegiacometti]

Created #27084

[htcfreek]

Created #27084

Canyou please dedup all the existing issues. I think it makes sense to do that.

[davidegiacometti]

@htcfreek what do you mean? Which issues?

[htcfreek]

@htcfreek what do you mean? Which issues?

I have in mind that there are multiple bug reports that peek can't preview files in archives.

[davidegiacometti]

@htcfreek maybe I am still misunderstanding but I think these are two things 🤯

• These bugs refer to Peek not able to preview file from an archived opened in Explorer.exe
• [Peek] Preview Files in Archives #27084 and @SamChaps feedback refer to be able to preview a file contained in the archive that is being previewed in Peek

[htcfreek]

@davidegiacometti
Yep. These are two things.🤯