[PT Run] Smooth scrolling of the results list #15033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes scrolling when using touchpad
stefansjfw
requested review from
crutkas,
yuyoyuppe,
SeraphimaZykova and
niels9001
yuyoyuppe
approved these changes
Dec 16, 2021
niels9001
approved these changes
Dec 17, 2021
jaimecbernardo
added a commit
to jaimecbernardo/PowerToys
that referenced
this pull request
Jan 10, 2022
This reverts commit 3ada3c2.
This was referenced Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes scrolling when using touchpad
According to this https://social.msdn.microsoft.com/Forums/vstudio/en-US/47bd6a75-7791-4c0f-93ae-931e9a6540e7/smooth-scrolling-on-listbox?forum=wpf, downside of this is we're losing virtualization. However, I don't expect that PT Run will produce amount of results to actually affect rendering of results list. I tested this with having hundreds of folders named
test_<numbers>and then querying fortestin PT Run. Also, it looks like PT Run (or plugins) have some limit of how many results can be shown. So we should be safe there.Summary of the Pull Request
What is this about:
What is included in the PR:
How does someone test / validate:
Open PT v0.51.1
start PT Run
Run some query that produces a lot of results
Try scrolling using laptop touchpad
observe that scrolling is too sensitive
Redo the steps using this branch
observe that scrolling with touchpad is less sensitive and smoother
Quality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.