[Runner]remove hotkeyEx when disabling a module (#15944)

microsoft · Feb 2, 2022 · dbde5e3 · dbde5e3
1 parent bed7f2a
commit dbde5e3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/runner/general_settings.cpp b/src/runner/general_settings.cpp
@@ -149,20 +149,23 @@ void apply_general_settings(const json::JsonObject& general_configs, bool save)
             {
                 continue;
             }
-            const bool module_inst_enabled = modules().at(name)->is_enabled();
+            PowertoyModule& powertoy = modules().at(name);
+            const bool module_inst_enabled = powertoy->is_enabled();
             const bool target_enabled = value.GetBoolean();
             if (module_inst_enabled == target_enabled)
             {
                 continue;
             }
             if (target_enabled)
             {
-                modules().at(name)->enable();
+                powertoy->enable();
             }
             else
             {
-                modules().at(name)->disable();
+                powertoy->disable();
             }
+            // Sync the hotkey state with the module state, so it can be removed for disabled modules.
+            powertoy.UpdateHotkeyEx();
         }
     }
 
@@ -221,6 +224,7 @@ void start_enabled_powertoys()
         if (!powertoys_to_disable.contains(name))
         {
             powertoy->enable();
+            powertoy.UpdateHotkeyEx();
         }
     }
 }
diff --git a/src/runner/powertoy_module.cpp b/src/runner/powertoy_module.cpp
@@ -74,11 +74,12 @@ void PowertoyModule::UpdateHotkeyEx()
 {
     CentralizedHotkeys::UnregisterHotkeysForModule(pt_module->get_key());
     auto container = pt_module->GetHotkeyEx();
-    if (container.has_value())
+    if (container.has_value() && pt_module->is_enabled())
     {
         auto hotkey = container.value();
         auto modulePtr = pt_module.get();
         auto action = [modulePtr](WORD modifiersMask, WORD vkCode) {
+            Logger::trace(L"{} hotkey Ex is invoked from Centralized keyboard hook", modulePtr->get_key());
             modulePtr->OnHotkeyEx();
         };