[Peek]Fix memory leak caused by unmanaged bitmaps not being freed (#3…

…4484)
microsoft · Sep 16, 2024 · 9bfee34 · 9bfee34
1 parent 37f2154
commit 9bfee34
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/modules/peek/Peek.FilePreviewer/FilePreview.xaml.cs b/src/modules/peek/Peek.FilePreviewer/FilePreview.xaml.cs
@@ -154,6 +154,9 @@ private async Task OnItemPropertyChanged()
             _cancellationTokenSource.Cancel();
             _cancellationTokenSource = new();
 
+            // Clear up any unmanaged resources before creating a new previewer instance.
+            (Previewer as IDisposable)?.Dispose();
+
             if (Item == null)
             {
                 Previewer = null;

diff --git a/src/modules/peek/Peek.FilePreviewer/Peek.FilePreviewer.csproj b/src/modules/peek/Peek.FilePreviewer/Peek.FilePreviewer.csproj
@@ -103,12 +103,6 @@
     </Page>
   </ItemGroup>
 
-  <ItemGroup>
-    <Page Update="Controls\UnsupportedFilePreview\FailedFallbackPreviewControl.xaml">
-      <Generator>MSBuild:Compile</Generator>
-    </Page>
-  </ItemGroup>
-
   <ItemGroup>
     <Page Update="FilePreview.xaml">
       <Generator>MSBuild:Compile</Generator>