-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
10 changed files
with
161 additions
and
162 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,133 +1,3 @@ | ||
<Project> | ||
<Import Project="src\Version.props" /> | ||
<PropertyGroup> | ||
<Copyright>Copyright (C) Microsoft Corporation. All rights reserved.</Copyright> | ||
<AssemblyCopyright>Copyright (C) Microsoft Corporation. All rights reserved.</AssemblyCopyright> | ||
<AssemblyProduct>PowerToys</AssemblyProduct> | ||
<AssemblyCompany>Microsoft Corp.</AssemblyCompany> | ||
<Company>Microsoft Corporation</Company> | ||
<Authors>Microsoft Corporation</Authors> | ||
<Product>PowerToys</Product> | ||
<NeutralLanguage>en-US</NeutralLanguage> | ||
<Platforms>x64;ARM64</Platforms> | ||
<PackageTags>PowerToys</PackageTags> | ||
<EnableNETAnalyzers>true</EnableNETAnalyzers> | ||
<AnalysisMode>Recommended</AnalysisMode> | ||
<_SkipUpgradeNetAnalyzersNuGetWarning>true</_SkipUpgradeNetAnalyzersNuGetWarning> | ||
<NuGetAuditMode>direct</NuGetAuditMode> | ||
<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion> <!-- Don't add source revision hash to the product version of binaries. --> | ||
<PlatformTarget>$(Platform)</PlatformTarget> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup Condition="'$(MSBuildProjectExtension)' == '.csproj'"> | ||
<Version>$(Version).0</Version> | ||
<RepositoryUrl>https://github.com/microsoft/PowerToys</RepositoryUrl> | ||
<RepositoryType>GitHub</RepositoryType> | ||
<TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup> | ||
<_PropertySheetDisplayName>PowerToys.Root.Props</_PropertySheetDisplayName> | ||
<ForceImportBeforeCppProps>$(MsbuildThisFileDirectory)\Cpp.Build.props</ForceImportBeforeCppProps> | ||
</PropertyGroup> | ||
|
||
<ItemGroup Condition="'$(MSBuildProjectExtension)' == '.csproj'"> | ||
<PackageReference Include="StyleCop.Analyzers"> | ||
<PrivateAssets>all</PrivateAssets> | ||
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
</PackageReference> | ||
<Compile Include="$(MSBuildThisFileDirectory)\src\codeAnalysis\GlobalSuppressions.cs" Link="GlobalSuppressions.cs" /> | ||
<AdditionalFiles Include="$(MSBuildThisFileDirectory)\src\codeAnalysis\StyleCop.json" Link="StyleCop.json" /> | ||
|
||
<PackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers"> | ||
<PrivateAssets>all</PrivateAssets> | ||
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
</PackageReference> | ||
</ItemGroup> | ||
|
||
<!-- Add ability to run tests via "msbuild /t:Test" --> | ||
<!-- | ||
Workaround an MSBuild bug where Microsoft.Common.Test.targets is missing from the Arm64 installation. | ||
See: https://github.com/dotnet/msbuild/pull/9984 | ||
NB 1: This means that using "/t:Test" is not supported for Arm64 builds and tests will need to be run in an alternate way, | ||
eg running tests in VS or invoking vstest.console directly. | ||
NB 2: <Sdk> elements do not support conditions, so this is also being worked around. | ||
Once the change referenced above is fixed, the ImportGroup below can be replaced with: | ||
<Sdk Name="Microsoft.Build.RunVSTest" Version="1.0.319" /> | ||
--> | ||
<ImportGroup Condition="'$(PROCESSOR_ARCHITECTURE)' != 'ARM64'"> | ||
<Import Project="Sdk.props" Sdk="Microsoft.Build.RunVSTest" Version="1.0.319" /> | ||
<Import Project="Sdk.targets" Sdk="Microsoft.Build.RunVSTest" Version="1.0.319" /> | ||
</ImportGroup> | ||
<PropertyGroup> | ||
<VSTestLogger>trx</VSTestLogger> | ||
<!-- | ||
RunVSTest by default uses %VSINSTALLDIR%\Common7\IDE\CommonExtensions\Microsoft\TestWindow\vstest.console.exe, | ||
but some of the CI scenarios don't define %VSINSTALLDIR%, so be explicit about where to look for vstest. | ||
Note: $(VsInstallRoot) is a built-in MSBuild property, so should always be defined. | ||
--> | ||
<VSTestToolPath>$(VsInstallRoot)\Common7\IDE\CommonExtensions\Microsoft\TestWindow</VSTestToolPath> | ||
<!-- No arm64 agents to run the tests. --> | ||
<RunVSTest Condition="'$(Platform)' == 'ARM64'">false</RunVSTest> | ||
</PropertyGroup> | ||
|
||
<!-- MSBuildCache --> | ||
<PropertyGroup> | ||
<!-- Off by default --> | ||
<MSBuildCacheEnabled Condition="'$(MSBuildCacheEnabled)' == ''">false</MSBuildCacheEnabled> | ||
|
||
<!-- In Azure pipelines, use Pipeline Caching as the cache storage backend. Otherwise, use the local cache. --> | ||
<MSBuildCachePackageName Condition="'$(TF_BUILD)' != ''">Microsoft.MSBuildCache.AzurePipelines</MSBuildCachePackageName> | ||
<MSBuildCachePackageName Condition="'$(MSBuildCachePackageName)' == ''">Microsoft.MSBuildCache.Local</MSBuildCachePackageName> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup Condition="'$(MSBuildCacheEnabled)' == 'true'"> | ||
<!-- Disable when running in a pipeline as the time to upload or download the massive .pch/.pchast to the cache is greater than the savings they provide. --> | ||
<UsePrecompiledHeaders Condition="'$(TF_BUILD)' != ''">false</UsePrecompiledHeaders> | ||
|
||
<!-- Change this to bust the cache --> | ||
<MSBuildCacheCacheUniverse Condition="'$(MSBuildCacheCacheUniverse)' == ''">202408150737</MSBuildCacheCacheUniverse> | ||
|
||
<!-- | ||
Visual Studio telemetry reads various ApplicationInsights.config files and other files after the project is finished, likely in a detached process. | ||
This is acceptable and should not impact cache correctness. | ||
--> | ||
<MSBuildCacheAllowFileAccessAfterProjectFinishFilePatterns> | ||
$(MSBuildCacheAllowFileAccessAfterProjectFinishFilePatterns); | ||
\**\ApplicationInsights.config; | ||
$(LocalAppData)\Microsoft\VSApplicationInsights\**; | ||
$(LocalAppData)\Microsoft\Windows\INetCache\**; | ||
A:\; | ||
E:\; | ||
$(windir)\**; | ||
</MSBuildCacheAllowFileAccessAfterProjectFinishFilePatterns> | ||
|
||
<!-- Unit tests of low-priv processes, eg the preview handler tests, may log to this location. --> | ||
<MSBuildCacheAllowFileAccessAfterProjectFinishFilePatterns> | ||
$(MSBuildCacheAllowFileAccessAfterProjectFinishFilePatterns); | ||
$(USERPROFILE)\AppData\LocalLow\Microsoft\PowerToys\**; | ||
</MSBuildCacheAllowFileAccessAfterProjectFinishFilePatterns> | ||
|
||
<!-- | ||
This repo uses a common output directory with many projects writing duplicate outputs. Allow everything, but note this costs some performance in the form of requiring | ||
the cache to use copies instead of hardlinks when pulling from cache. | ||
--> | ||
<MSBuildCacheIdenticalDuplicateOutputPatterns>$(MSBuildCacheIdenticalDuplicateOutputPatterns);**</MSBuildCacheIdenticalDuplicateOutputPatterns> | ||
|
||
<!-- version of MSBuildCache is not part of the cache key --> | ||
<PackagesConfigFile>$(MSBuildThisFileDirectory)packages.config</PackagesConfigFile> | ||
<MSBuildCacheIgnoredInputPatterns>$(MSBuildCacheIgnoredInputPatterns);$(PackagesConfigFile)</MSBuildCacheIgnoredInputPatterns> | ||
</PropertyGroup> | ||
|
||
<PropertyGroup Condition="'$(MSBuildCacheEnabled)' == 'true' and '$(MSBuildCachePackageRoot)' == ''"> | ||
<PackagesConfigContents>$([System.IO.File]::ReadAllText("$(PackagesConfigFile)"))</PackagesConfigContents> | ||
<MSBuildCachePackageVersion>$([System.Text.RegularExpressions.Regex]::Match($(PackagesConfigContents), 'Microsoft.MSBuildCache.*?version="(.*?)"').Groups[1].Value)</MSBuildCachePackageVersion> | ||
<MSBuildCachePackageRoot>$(MSBuildThisFileDirectory)packages\$(MSBuildCachePackageName).$(MSBuildCachePackageVersion)</MSBuildCachePackageRoot> | ||
<MSBuildCacheSharedCompilationPackageRoot>$(MSBuildThisFileDirectory)packages\Microsoft.MSBuildCache.SharedCompilation.$(MSBuildCachePackageVersion)</MSBuildCacheSharedCompilationPackageRoot> | ||
</PropertyGroup> | ||
|
||
<ImportGroup Condition="'$(MSBuildCacheEnabled)' == 'true'"> | ||
<Import Project="$(MSBuildCachePackageRoot)\build\$(MSBuildCachePackageName).props" /> | ||
<Import Project="$(MSBuildCacheSharedCompilationPackageRoot)\build\Microsoft.MSBuildCache.SharedCompilation.props" /> | ||
</ImportGroup> | ||
<Import Project="$(MSBuildThisFileDirectory)\custom.props" /> | ||
</Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,3 @@ | ||
<Project> | ||
<Sdk Name="Microsoft.Build.CopyOnWrite" Version="1.0.282" /> | ||
|
||
<Import Project="$(MSBuildCachePackageRoot)\build\$(MSBuildCachePackageName).targets" Condition="'$(MSBuildCacheEnabled)' == 'true'" /> | ||
<Import Project="$(MSBuildCacheSharedCompilationPackageRoot)\build\Microsoft.MSBuildCache.SharedCompilation.targets" Condition="'$(MSBuildCacheEnabled)' == 'true'" /> | ||
</Project> | ||
<Import Project="$(MSBuildThisFileDirectory)\custom.targets" /> | ||
</Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
5576203
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@check-spelling-bot Report
🔴 Please review
See the 📜action log or 📝 job summary for details.
Unrecognized words (2)
BINARYVERSION
XES
Previously acknowledged words that are now absent
applayout appsfolder cswinrt systemsettings SYSTEMWOW USEPOSITION USESIZE 🫥To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands
... in a clone of the [email protected]:microsoft/PowerToys.git repository
on the
dev/duhowett/versioning
branch (ℹ️ how do I use this?):Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionary
This includes both expected items (1897) from .github/actions/spell-check/expect.txt and unrecognized words (2)
Consider adding them (in
.github/workflows/spelling2.yml
) foruses: check-spelling/[email protected]
in itswith
:To stop checking additional dictionaries, add (in
.github/workflows/spelling2.yml
) foruses: check-spelling/[email protected]
in itswith
:Warnings (1)
See the 📜action log or 📝 job summary for details.
See ℹ️ Event descriptions for more information.
If the flagged items are 🤯 false positives
If items relate to a ...
binary file (or some other file you wouldn't want to check at all).
Please add a file path to the
excludes.txt
file matching the containing file.File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.
^
refers to the file's path from the root of the repository, so^README\.md$
would exclude README.md (on whichever branch you're using).well-formed pattern.
If you can write a pattern that would match it,
try adding it to the
patterns.txt
file.Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.
Note that patterns can't match multiline strings.