Engine: Improve output structure, CLI: Configurable model options, Separate finetune
+generate-adapter
#1361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Engine:
output_name
is removed from both pass config and engine config.output_name
is arbitrary. User can get the output in a specific folder by directly providing theoutput_dir
likeparent-dir/specific-dir
.output_name
was allowed for pass config to save intermediate models. But this can be achieved by providing multiple pass flows like[[A, B], [A, B, C]]
. This is cleaner than the former.Engine.run
for more details on the new output structure.CLI:
add_model_options
is made configurable so that only the desired model type related options are added.save_output_model
uses the new engine output directory structure to copy the output model into the final output directory.finetune
command separated intofinetune
andgenerate-adapter
commands. These commands can be chained as shown in the llama2 multilora notebook.Checklist before requesting a review
lintrunner -a
(Optional) Issue link