Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hprof parser and inspector #325

Merged
merged 14 commits into from
Jun 21, 2023
Merged

hprof parser and inspector #325

merged 14 commits into from
Jun 21, 2023

Conversation

TedaLIEz
Copy link
Contributor

@TedaLIEz TedaLIEz commented Mar 3, 2023

Inspector android application with memory dump, and parse the generated hprof file.

@taoran6
Copy link
Collaborator

taoran6 commented Mar 5, 2023

@TedaLIEz, do we have the capability to parse the memory leak from memory dump?

@TedaLIEz
Copy link
Contributor Author

TedaLIEz commented Mar 6, 2023

@TedaLIEz, do we have the capability to parse the memory leak from memory dump?
@taoran6 No, this doesn't cover the memory leak detection. To do so, we need to make our test framework be aware of Android UI components' lifecycle.

@TedaLIEz TedaLIEz marked this pull request as draft March 6, 2023 03:07
@hydraxman
Copy link
Member

I think this function is useful, will we continue working on this? @TedaLIEz let me know if something is blocking this.

@TedaLIEz TedaLIEz marked this pull request as ready for review May 25, 2023 06:42
@TedaLIEz TedaLIEz requested a review from AC-Phoenix as a code owner May 25, 2023 06:42
taoran6
taoran6 previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@taoran6 taoran6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

@TedaLIEz TedaLIEz enabled auto-merge (squash) June 21, 2023 07:35
@TedaLIEz TedaLIEz merged commit 889005a into main Jun 21, 2023
5 checks passed
@TedaLIEz TedaLIEz deleted the user/guojian/feat_dumphprof branch June 21, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinghong2233 dinghong2233 dinghong2233 left review comments

@taoran6 taoran6 taoran6 approved these changes

@AC-Phoenix AC-Phoenix Awaiting requested review from AC-Phoenix AC-Phoenix is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TedaLIEz @taoran6 @hydraxman @dinghong2233