Skip to content

Commit

Permalink
Bugfix: update front page of task list to display the status of analy…
Browse files Browse the repository at this point in the history
…sis task (#645)

<!-- Please provide brief information about the PR, what it contains &
its purpose, new behaviors after the change. And let us know here if you
need any help: https://github.com/microsoft/HydraLab/issues/new -->

## Description

<!-- A few words to explain your changes -->

### Linked GitHub issue ID: #  

## Pull Request Checklist
<!-- Put an x in the boxes that apply. This is simply a reminder of what
we are going to look for before merging your code. -->

- [ ] Tests for the changes have been added (for bug fixes / features)
- [x] Code compiles correctly with all tests are passed.
- [x] I've read the [contributing
guide](https://github.com/microsoft/HydraLab/blob/main/CONTRIBUTING.md#making-changes-to-the-code)
and followed the recommended practices.
- [ ] [Wikis](https://github.com/microsoft/HydraLab/wiki) or
[README](https://github.com/microsoft/HydraLab/blob/main/README.md) have
been reviewed and added / updated if needed (for bug fixes / features)

### Does this introduce a breaking change?
*If this introduces a breaking change for Hydra Lab users, please
describe the impact and migration path.*

- [ ] Yes
- [x] No

## How you tested it
*Please make sure the change is tested, you can test it by adding UTs,
do local test and share the screenshots, etc.*


Please check the type of change your PR introduces:
- [ ] Bugfix
- [ ] Feature
- [ ] Technical design
- [ ] Build related changes
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Code style update (formatting, renaming) or Documentation content
changes
- [ ] Other (please describe): 

### Feature UI screenshots or Technical design diagrams
*If this is a relatively large or complex change, kick it off by drawing
the tech design with PlantUML and explaining why you chose the solution
you did and what alternatives you considered, etc...*

![image](https://github.com/microsoft/HydraLab/assets/26757995/833dfe9f-7317-480c-b77d-9c80113de4fa)


![image](https://github.com/microsoft/HydraLab/assets/26757995/3830abd3-657f-4f32-b822-3557e0798fcf)
  • Loading branch information
zhou9584 committed Jan 23, 2024
1 parent 1759555 commit 50e72ec
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions react/src/component/TasksView.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -563,11 +563,8 @@ class TasksView extends BaseView {
</PieChart>
</td>
<td style={{ fontSize: '0.875rem' }}>
{task.overallSuccessRate}({
task.totalTestCount ? (task.totalTestCount - task.totalFailCount) + '/' + task.totalTestCount : 0


})
{task.overallSuccessRate}
{task.totalTestCount ? '(' +(task.totalTestCount - task.totalFailCount) + '/' + task.totalTestCount+ ')' : task.status}
</td>
</tr>
</tbody>
Expand Down

0 comments on commit 50e72ec

Please sign in to comment.