Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument whether Summary includes partial batch chunks #22500

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

markfields
Copy link
Member

Description

Based on the fact that inbound batches are always processed synchronously, we don't believe the RemoteMessageProcessor will ever have a partial batch in-flight when Summary happens. But maybe there are cases I'm not thinking of.

This change adds a stat to Summarizer's telemetryContext indicating how many chunks were added - or remains undefined if none.

After 2.3 ships we can look for this in the logs to find out if this ever happens at scale.

We don't think this ever happens in practice.
@github-actions github-actions bot added area: runtime Runtime related issues base: main PRs targeted against main branch labels Sep 13, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +677 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.26 KB 460.4 KB +143 Bytes
azureClient.js 558.25 KB 558.4 KB +157 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 261.02 KB 261.14 KB +122 Bytes
fluidFramework.js 401.41 KB 401.42 KB +14 Bytes
loader.js 134.24 KB 134.25 KB +14 Bytes
map.js 42.43 KB 42.44 KB +7 Bytes
matrix.js 146.58 KB 146.58 KB +7 Bytes
odspClient.js 525.54 KB 525.69 KB +157 Bytes
odspDriver.js 97.85 KB 97.87 KB +21 Bytes
odspPrefetchSnapshot.js 42.81 KB 42.82 KB +14 Bytes
sharedString.js 163.3 KB 163.31 KB +7 Bytes
sharedTree.js 391.87 KB 391.88 KB +7 Bytes
Total Size 3.3 MB 3.3 MB +677 Bytes

Baseline commit: 9e74c7c

Generated by 🚫 dangerJS against 40c6fe3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants