Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

25.x - Page summary telemetry - fix wrong condition #2054

Merged
merged 2 commits into from
Sep 17, 2024
Merged

25.x - Page summary telemetry - fix wrong condition #2054

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8728f3e
Fixing the telemetry reporting
nikolakukrika Sep 17, 2024
2754eb7
Fixing telemetry
nikolakukrika Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 3 additions & 19 deletions src/System Application/App/Page Summary Provider/src/PageSummaryProviderImpl.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ codeunit 2717 "Page Summary Provider Impl."

procedure GetPageSummary(PageSummaryParameters: Record "Page Summary Parameters"): Text
begin
if PageSummaryParameters."Page ID" = 0 then
ThrowPageMustBeSpecifiedError();

if PageSummaryParameters.Bookmark <> '' then
exit(GetPageSummary(PageSummaryParameters."Page ID", PageSummaryParameters.Bookmark, PageSummaryParameters."Include Binary Data"));

Expand Down Expand Up @@ -149,10 +146,8 @@ codeunit 2717 "Page Summary Provider Impl."
Clear(PageSummarySettings);

PageSummaryJsonObject.ReadFrom(JsonText);
if not PageSummaryJsonObject.Get(PageIDTok, ParsedJsonToken) then
ThrowPageMustBeSpecifiedError();

PageSummaryParameters."Page ID" := ParsedJsonToken.AsValue().AsInteger();
if PageSummaryJsonObject.Get(PageIDTok, ParsedJsonToken) then
PageSummaryParameters."Page ID" := ParsedJsonToken.AsValue().AsInteger();

if PageSummaryJsonObject.Get(BookmarkTok, ParsedJsonToken) then
#pragma warning disable AA0139
Expand Down Expand Up @@ -200,7 +195,7 @@ codeunit 2717 "Page Summary Provider Impl."
local procedure GetRecordFields(PageId: Integer; Bookmark: Text; var ResultJsonObject: JsonObject)
begin
// Get all visible and available table fields that back the controls that are visible on the page
if TryGetAvailableRecordFieldsData(PageId, Bookmark, ResultJsonObject) then
if not TryGetAvailableRecordFieldsData(PageId, Bookmark, ResultJsonObject) then
Session.LogMessage('0000NFZ', StrSubstNo(GetRecordFieldsFailureTelemetryTxt, PageId), Verbosity::Error, DataClassification::SystemMetadata, TelemetryScope::ExtensionPublisher, 'Category', PageSummaryCategoryLbl);
exit;
end;
Expand Down Expand Up @@ -441,16 +436,6 @@ codeunit 2717 "Page Summary Provider Impl."
ExtractPictureFromMedia(TenantMediaSet."Media ID".MediaId, FieldValue, MimeType, FieldType);
end;

local procedure ThrowPageMustBeSpecifiedError()
var
ProgrammingErrorInfo: ErrorInfo;
begin
ProgrammingErrorInfo.Verbosity := Verbosity::Error;
ProgrammingErrorInfo.ErrorType := ProgrammingErrorInfo.ErrorType::Internal;
ProgrammingErrorInfo.Message := PageIDMustBeSpecifiedErr;
Error(ProgrammingErrorInfo);
end;

var
PageSummarySettings: Codeunit "Page Summary Settings";
PageTxt: Label 'Page %1', Comment = '%1 is a whole number, ex. 10';
Expand All @@ -467,7 +452,6 @@ codeunit 2717 "Page Summary Provider Impl."
GetPageUrlSuccessTelemetryTxt: Label 'Successfully added url for page %1.', Locked = true;
NoRecordFieldsFoundTelemetryTxt: Label 'No record fields found for page %1.', Locked = true;
GetRecordFieldsFailureTelemetryTxt: Label 'Failure to get record fields for page %1.', Locked = true;
PageIDMustBeSpecifiedErr: Label 'Page ID must be specified.', Locked = true;
PageIDTok: Label 'pageId', Locked = true;
RecordSystemIdTok: Label 'recordSystemId', Locked = true;
BookmarkTok: Label 'bookmark', Locked = true;
Expand Down
Loading