Skip to content

Commit

Permalink
code review suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
blrobl committed Sep 25, 2024
1 parent 8f9ffeb commit 7a75f0e
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ codeunit 8333 "VS Code Integration Impl."
InherentPermissions = X;

var
AllObjWithCaption: Record AllObjWithCaption;
UriBuilder: Codeunit "Uri Builder";
VSCodeRequestHelper: DotNet VSCodeRequestHelper;
AlExtensionUriTxt: Label 'vscode://ms-dynamics-smb.al', Locked = true;
Expand Down Expand Up @@ -105,6 +104,8 @@ codeunit 8333 "VS Code Integration Impl."

[Scope('OnPrem')]
local procedure FormatObjectType(ObjectType: Option): Text
var
AllObjWithCaption: Record AllObjWithCaption;
begin
case ObjectType of
AllObjWithCaption."Object Type"::Page:
Expand All @@ -119,6 +120,7 @@ codeunit 8333 "VS Code Integration Impl."
[Scope('OnPrem')]
local procedure GetAppIdForObject(ObjectType: Option; ObjectId: Integer): Text
var
AllObjWithCaption: Record AllObjWithCaption;
NavAppInstalledApp: Record "NAV App Installed App";
EmptyGuid: Guid;
begin
Expand All @@ -127,7 +129,6 @@ codeunit 8333 "VS Code Integration Impl."
exit(EmptyGuid);

if AllObjWithCaption.ReadPermission() then begin
AllObjWithCaption.Reset();
AllObjWithCaption.SetRange("Object Type", ObjectType);
AllObjWithCaption.SetRange("Object ID", ObjectId);

Expand Down

0 comments on commit 7a75f0e

Please sign in to comment.