Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve expiring locks display with filtering and pagination #842

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

francesmcmullin
Copy link
Contributor

I found some issues with the expiring locks tab when trying to troubleshoot another problem. This is a fairly naive improvement with a lot of repetition, I just wasn't sure what level of path/context was available from the lock.erb template so I just made a separate one. Without these changes, it's not possible to filter or paginate on the Expiring Locks page.

Also included here - deleting all locks was failing due to a typo in that method, deleting expiring digests based on the regular digests.count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant