Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Sidekiq 7.2 throws TypeError: Unsupported command argument type: TrueClass when using byscore: true #815

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: Sidekiq 7.2 throws TypeError: Unsupported command argument type: TrueClass when using byscore: true #815

merged 1 commit into from
Nov 9, 2023

Conversation

Amnesthesia
Copy link
Contributor

According to Sidekiq 7.2 changelog, using byscore: true and nx: true will now throw, which causes Sidekiq not to start up anymore when using sidekiq-unique-jobs

@mhenrixon mhenrixon enabled auto-merge (squash) November 1, 2023 08:28
@kwent
Copy link

kwent commented Nov 2, 2023

Much needed ! Can we cut a new release with this patch ?

@ReazerDev ReazerDev mentioned this pull request Nov 2, 2023
Closed
auto-merge was automatically disabled November 2, 2023 23:09

Head branch was pushed to by a user without write access

@Amnesthesia
Copy link
Contributor Author

Much needed ! Can we cut a new release with this patch ?

Hope so, fixed linting and specs but workflow requires approval — hoping it's green now 🤞

@mhenrixon mhenrixon mentioned this pull request Nov 6, 2023
Closed
@mhenrixon mhenrixon linked an issue Nov 6, 2023 that may be closed by this pull request
Sidekiq 7: Unsupported command argument type: TrueClass #816
Closed
@Amnesthesia Amnesthesia force-pushed the fix/sidekiq-7.2-TypeError-TrueClass branch from 140f813 to 8dd13fa Compare November 8, 2023 23:51
@Amnesthesia
Copy link
Contributor Author

Any way you can approve workflow runs to run for the rest of the PR rather than for each commit? Doesn't it defeat the purpose of turning on auto-merge, if merge depends on workflows and workflows wont run without approval on each push?

@mhenrixon
Copy link
Owner

Any way you can approve workflow runs to run for the rest of the PR rather than for each commit? Doesn't it defeat the purpose of turning on auto-merge, if merge depends on workflows and workflows wont run without approval on each push?

I don't even care to approve. I need to check the settings. This is absolutely ridiculous.

Also, I will remove reek. It seems a little overkill to be honest.

@mhenrixon mhenrixon merged commit 8c9f633 into mhenrixon:main Nov 9, 2023
6 of 8 checks passed
@mhenrixon mhenrixon mentioned this pull request Nov 9, 2023
Closed
semenyukdmitry pushed a commit to UniversalAvenue/sidekiq-unique-jobs that referenced this pull request Jan 8, 2024
@Amnesthesia @semenyukdmitry
fix: Sidekiq 7.2 throws TypeError: Unsupported command argument type:…
8d2a211 
… TrueClass when using byscore: true (mhenrixon#815)

fix: Sidekiq 7.2 TypeError: invalid type TrueClass
semenyukdmitry pushed a commit to UniversalAvenue/sidekiq-unique-jobs that referenced this pull request Jan 8, 2024
@Amnesthesia @semenyukdmitry
fix: Sidekiq 7.2 throws TypeError: Unsupported command argument type:…
0d25c3c 
… TrueClass when using byscore: true (mhenrixon#815)

fix: Sidekiq 7.2 TypeError: invalid type TrueClass
@dljsjr dljsjr mentioned this pull request Mar 2, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sidekiq 7: Unsupported command argument type: TrueClass
3 participants
@Amnesthesia @kwent @mhenrixon