fix: while_executing should not invoke conflict strategy when the job was successfully executed [v8]
#810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The rubocop setting changed recently? Or was any dependency updated? I tried to fix the error on the rubocop spec, but it found 59 new offenses on my branch. I don't think it is related to this PR, and as it is a lot of offenses, it would pollute the PR with the fixes. Do you want me to open another PR to fix it, or I'm missing something? |
mhenrixon
force-pushed
the
fix-infinity-loop-on-using-while-executing
branch
from
7b0f872
to
9a2b431
Compare
mhenrixon
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, I didn't find any PR fixing it to the 8 version, we are not updating the gem to v8.0.3 because of this error. I found the solution for the v7.1 here #806 and only replicated it. So if it works, all the credits go to @leandrogoe.
Let me know if it is something useful or if I missed something, but as far as I can see, we didn't open a PR fixing it to v8+, right?
It should fix the #800