Fixes issue #800 of sidekiq unique jobs

mhenrixon · Aug 19, 2023 · 34cd7c2 · 34cd7c2
1 parent 9682f16
commit 34cd7c2
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lib/sidekiq_unique_jobs/lock/while_executing.rb b/lib/sidekiq_unique_jobs/lock/while_executing.rb
@@ -42,6 +42,7 @@ def execute(&block)
         with_logging_context do
           executed = locksmith.execute do
             yield
+            item[JID]
           ensure
             unlock_and_callback
           end

diff --git a/spec/sidekiq_unique_jobs/lock/while_executing_spec.rb b/spec/sidekiq_unique_jobs/lock/while_executing_spec.rb
@@ -91,10 +91,12 @@
 
       it "reflects execution_failed" do
         process_one.execute do
-          process_two.execute { puts "BOGUS!" }
-          # NOTE: Below looks weird but tests that
-          #   the result from process_two (which is nil) isn't considered.
-          jid_one
+          process_two.execute {
+            puts "BOGUS!"
+            nil
+          }
+
+          nil
         end
 
         expect(process_one).not_to have_received(:reflect).with(:execution_failed, item_one)