base path returned for nonexistent route instead of throwing exception #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jurj-Bogdan <[email protected]>
|
This should be handled in the view layer. Layouts and partials should take care not to generate URIs with invalid routing information, such as rendering a url for the current un-matched route. This change effectively means - "If the matched route is a 404, then generate an invalid URI for the given parameters". Typically, I prefer the exception. |
|
The linked navigation partial should be fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Invoking UrlHelper while on an invalid route will lead to a RuntimeException being thrown, which in the case of laminas/getlaminas.org will prevent the error page from being rendered altogether (as mentioned in #191 of getlaminas.org, which was the starting point for this PR).
In getlaminas' case, the exception is triggered by calling
$this->url()in the navigation partial when accessing a nonexistent route.One potential fix would be preventing this exception from being thrown and returning the valid base url, as implemented in this PR. However, it would be a BC break for anyone trusting this exception to be thrown.
There are multiple ways to fix this problem, in different repositories - maybe by handling the exception in mezzio/mezzio's NotFoundHandler, or in getlaminas.org itself. I am open to suggestions on how else to handle this issue.