Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Mangadex provider sorting to show more relevant results #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zutto
Copy link

@zutto zutto commented May 19, 2024

Hi,

So I was doing some searching with the inline feature and noted that some random Mangadex entries just refuse to match with --manga exact.

After a bit of research, I noted that this happens when certain conditions are met:

  • count of results from Mangadex's search API is higher than the limit in the code (100).
  • Is sorted unfavorably in Mangadex.

Example that I found after a bit of trial and error:
mangal -S Mangadex inline --query 'HA-HA' --manga 'exact' -j returns a lot of results (755 at the moment of writing this)
This example case gets sorted after the limit, and thus will never be found by mangal. Workaround for this is to search altTitles, but in my very personal opinion, I think it would be more user friendly to use Mangadex's sorting algorithm to show us relevant results rather than sort by some other statistic.

Feel free to reject the PR if you feel this is not something we don't want to change.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant