Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optim - added quantization code. #968

Open
wants to merge 70 commits into
base: main
Choose a base branch
from

Conversation

sgsharma2000
Copy link

@sgsharma2000 sgsharma2000 commented Dec 14, 2023

Added quantization code mainly inside generator.py and model.py - but show very marginal improvements in timing for batch sizes.

@facebook-github-bot
Copy link

Hi @sgsharma2000!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@subramen
Copy link
Contributor

Hi @sgsharma2000 firstly thank you for submitting this (fairly large) PR!

Reviewing your proposed changes will be much easier if you could batch your changes across multiple smaller and narrowly-scoped PRs. Please also include information on what changes you've made, what are you trying to achieve, and the rationale for your approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants