-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Updates: routing table, models endpoint, inference routing, rebase on safety_refactor #85
Open
yanxi0830
wants to merge
45
commits into
safety_refactor
Choose a base branch
from
new_router
base: safety_refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Meta Open Source bot.
label
Sep 20, 2024
Sample adapter implementation for Bedrock implementation of Guardrails
This reverts commit fa04d86.
This reverts commit 164d0e2.
This reverts commit 6a95edc.
This reverts commit 756e98c.
This reverts commit bc4ac2c.
This reverts commit d8fab77.
This reverts commit 08379f5.
This reverts commit 34f0c11.
This reverts commit 73399fe.
yanxi0830
changed the title
[WIP] new router migration
API Updates: routing table, models endpoint, inference routing, rebase on safety_refactor
Sep 22, 2024
This reverts commit fa04d86.
yanxi0830
requested review from
ashwinb,
hardikjshah,
dltn and
raghotham
as code owners
September 22, 2024 07:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Major Changes
✅ rebase on top of safety_refactor branch
✅ routers migration
- move memory router to use
llama_stack/distribution/routers
- add
RoutingTable
class with to manage provider implementations- add inference routing based on
model
param to use different models✅
models/list
&models/get
endpoint to query information on what model is currently being served & corresponding api provider- 1 adapter could support multiple models (e.g. fireworks/together/ollama), for this case, we list all supported models by the adapter
✅
safety/list_shields
to query available shields in distributionMinor Changes
✅ backward compatibility: single adapter without routing implementation still supported
✅ example configs to configure advanced routing table
✅ configure script to configure single adapter backed endpoints
Not in this PR
🚧
register_model
endpoint to add new models🚧 Client CLI for querying distribution models endpoint --> will be in
llama-stack-apps
🚧 Update client SDK package to deal with new OpenAPI spec on run_shield
Tests
Routing Table
Test Inference Routing
Test Memory Routing
vector memory type
switch to keyvalue memory type remote::pgvector
Test Agents
Test Safety
Models Endpoint with Routing Table
Models Endpoint without Routing Table
run.yaml