Add API keys to AgenticSystemConfig instead of relying on dotenv #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Looks good, assuming you ran test_e2e and it was all ok ? |
hardikjshah
approved these changes
Aug 21, 2024
llama_toolchain/cli/download.py
Outdated
| @@ -178,6 +178,9 @@ class ModelEntry(BaseModel): | |||
| model_id: str | |||
| files: Dict[str, str] | |||
|
|
|||
| class Config: | |||
There was a problem hiding this comment.
why is this needed in this PR ?
There was a problem hiding this comment.
it is technically not needed. it's an independent warning-fix. I can separately commit it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since we introduced distributions, "internal" tools like Brave / Wolfram were broken. This was because we got their keys from
.env, but the CWD for starting the distribution was inside the installedllama_toolchainpackage. There's no way a user could put a.envthere.Instead, I am moving the API keys specification to the
AgenticSystemConfig-- a more natural place.