-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: add License, Maintainers, and Funding sections #445
Conversation
@rgommers What's the copyright blurb we should use for the Quansight logo? |
Good question. I think the options are:
This has got to be a common question, because a ton of projects use logos like this. I'm not aware of a single canonical way to treat copyright statements though - I'll do some searching. |
Common question, but there is no good answer. I think it's actually an annoyance for packagers to have this logo image included, because it is the kind of thing that has to be treated with care. For most projects this doesn't come up because logos go on a website, which is kept in a separate repo from the code and docs so there's no cross-talk to an sdist and other redistributable artifacts for the software package. The easiest thing here is to get rid of it. That's too bad, but attribution in text is also fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo my couple of minor comments.
also, |
|
PyPI does not host detached PGP signatures anymore.
All fixed. I've also added one more commit on top. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks. Renaming Security to Packages sounds good to me, because it's not really about Security. For a section named Security, I'd expect a security vulnerability disclosure policy or some such thing.
Please consider my proposed rephrase - either way this is good to go in.
This replaces #354.
The left-hand-side index on the documentation pages gets again a bit too long, but I cannot think to an organization of these sections that makes sense and spares top level index entries. Suggestions are welcome.