Commitlint: Accept standard git revert commits #240
Conversation
Signed-off-by: Ole Petter <[email protected]>
commitlint/testcommitlint.sh
Outdated
| @@ -451,5 +451,11 @@ Changelog: none | |||
| Signed-off-by: Kristian Amlie <[email protected]>" | |||
|
|
|||
|
|
|||
| assert "true" \ | |||
| "Accept standard git-revert commits" \ | |||
| "Revert build(docker-client): Add support for building the cpp-client | |||
There was a problem hiding this comment.
In reality, the title of the old commit is quoted: Revert "build(docker-client): Add support for building the cpp-client". Will this still work with the parser?
There was a problem hiding this comment.
hah, good catch! I copy pasted, and was like: Wtf is these extra quotes doing here...
There was a problem hiding this comment.
And it broke... 😞
There was a problem hiding this comment.
Fixed.
One other thing, is that we probably shouldn't parse these commits at all.
There was a problem hiding this comment.
One other thing, is that we probably shouldn't parse these commits at all.
We have to parse the commits. The git revert will only keep the title and "This reverts commit blablabla", but the user most likely appends some context on why the revert is there and possibly have a changelog.
oleorhagen
force-pushed
the
fix-revert-commitlint
branch
from
3e565ec
to
571ee2f
Compare
Ticket: None Changelog: None Signed-off-by: Ole Petter <[email protected]>
Signed-off-by: Ole Petter <[email protected]>
oleorhagen
force-pushed
the
fix-revert-commitlint
branch
from
73cfb6c
to
11ecb17
Compare
Also add better debug prints