Auto eject round robin #8219
Draft
Auto eject round robin #8219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pupnewfster
reviewed
Aug 28, 2024
| @@ -403,6 +405,14 @@ public <BE extends BlockEntity & IAdvancedTransportEjector> TransitResponse inse | |||
| return insert(outputter, outputterPos, request, color, doEmit, min); | |||
| } | |||
|
|
|||
| public TransitResponse insertMaybeRR(@NotNull TileEntityConfigurableMachine outputter, BlockPos outputterPos, TransitRequest request, @Nullable EnumColor color, boolean doEmit, int min) { | |||
There was a problem hiding this comment.
Instead of duplicating methods like this, would it maybe make more sense to have TileEntityConfigurableMachine just implement IAdvancedTransportEjector and wrap the calls to the implementation on TileComponentEjector?
There was a problem hiding this comment.
Main reason I didn't is that it avoids the custom send home methods being needed
But that could be implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Gives machines with a Transporter config the ability to do round robin auto-eject like a logistical sorter
Todo