Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-0.9] Some fixes and e2e test improvements #233

Merged
merged 2 commits into from
Jul 9, 2024
Merged

[release-0.9] Some fixes and e2e test improvements #233

merged 2 commits into from
Jul 9, 2024

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #226

/assign slintes

clobrano and others added 2 commits July 9, 2024 18:00
@clobrano
Some fixes and e2e test improvements:
5f7fdb5 
- re-enable and fix api check log tests in e2e test
  - use service IP for killing API connection
  - kill API connection on SNR DS pod
  - add peer check server logs and use them for test which can't
    get logs from unhealthy node's SNR agent pod
  - wait for pod deletion only, not restart (restart is caused by
    reboot, not SNR)
- refactor / cleanup e2e tests
- fix owner check / node name / machine name in peer check server
  and agent reconciler
- update sort-imports, which ignores generated files now
@slintes
small adjustments
29b96f7 
- make some functions private
- improve logs message

Signed-off-by: Marc Sluiter <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 9, 2024
Merged
@openshift-ci openshift-ci bot requested review from beekhof and clobrano July 9, 2024 18:00
@slintes
Copy link
Member

slintes commented Jul 9, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Jul 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, slintes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 9, 2024
@slintes
Copy link
Member

slintes commented Jul 9, 2024

/retest

@slintes
Copy link
Member

slintes commented Jul 9, 2024

flaky tests issues:

4.12: snr pod not ready in time
4.13: expected boot time differs by 1s??

  [FAILED] Failed after 4.053s.
  Expected
      <time.Time>: 2024-07-09T18:30:57Z
  to be ==
      <time.Time>: 2024-07-09T18:30:58Z

@slintes
Copy link
Member

slintes commented Jul 9, 2024

both 4.12 and 4.13: strange error on one ds pod:

"container create failed: time="2024-07-09T21:30:09Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T21:30:09Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T21:30:09Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T21:30:09Z" level=error msg="runc create failed: unable to start container process: exec: \"/manager\": stat /manager: no such file or directory" "

4.12 was green on main, so I'm pretty sure this is unrelated to this change

/override ci/prow/4.12-openshift-e2e
/override ci/prow/4.13-openshift-e2e

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

@slintes: Overrode contexts on behalf of slintes: ci/prow/4.12-openshift-e2e, ci/prow/4.13-openshift-e2e

In response to this:

both 4.12 and 4.13: strange error on one ds pod:

"container create failed: time="2024-07-09T21:30:09Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T21:30:09Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T21:30:09Z" level=warning msg="cgroup: subsystem does not exist" time="2024-07-09T21:30:09Z" level=error msg="runc create failed: unable to start container process: exec: \"/manager\": stat /manager: no such file or directory" "

4.12 was green on main, so I'm pretty sure this is unrelated to this change

/override ci/prow/4.12-openshift-e2e
/override ci/prow/4.13-openshift-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit a4408ea into medik8s:release-0.9 Jul 9, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beekhof beekhof Awaiting requested review from beekhof

@clobrano clobrano Awaiting requested review from clobrano

Assignees

@slintes slintes

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @slintes @clobrano