Simplify naming for condition #231
Conversation
Currently when SNR is disabled because of missing configuration, the condition's reason is "SNRDisabledConfigurationNotFound", however - we already know it's about SNR - we know, from the type, that is about "Disable" so we can simplify the `reason` to "ConfigurationNotFound". ECOPROJECT-2026 Signed-off-by: Carlo Lobrano <[email protected]>
|
Skipping CI for Draft Pull Request. |
|
/test 4.15-openshift-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clobrano, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.9 |
|
@clobrano: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@clobrano: new pull request created: #232 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why we need this PR
Currently when SNR is disabled because of missing configuration, the
condition's reason is "SNRDisabledConfigurationNotFound", however
Changes made
Which issue(s) this PR fixes
https://issues.redhat.com/browse/ECOPROJECT-2026
Test plan