WIP Test e2e #223
WIP Test e2e #223
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test 4.15-openshift-e2e |
1 similar comment
|
/test 4.15-openshift-e2e |
| @@ -535,7 +542,7 @@ func checkSnrLogs(node *v1.Node, expected []string) { | |||
|
|
|||
| EventuallyWithOffset(1, func() string { | |||
| var err error | |||
| logs, err := utils.GetLogs(k8sClientSet, pod) | |||
| logs, err := utils.GetLogs(k8sClientSet, pod, since) | |||
| }) | ||
|
|
||
| JustAfterEach(func() { | ||
| printSNRLogsFromNode(&workers.Items[1]) | ||
| // TODO why worker 1?? |
There was a problem hiding this comment.
No idea, it must be a mistake
There was a problem hiding this comment.
ah no, it comes from a "refactory", originally it was the log of healthyNode := &workers.Items[1]
There was a problem hiding this comment.
I could've kept at least the variable name to make it clearer
|
/test 4.15-openshift-e2e |
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Carlo Lobrano <[email protected]>
Signed-off-by: Marc Sluiter <[email protected]>
don't restart pods but use SinceTime option Signed-off-by: Marc Sluiter <[email protected]>
Signed-off-by: Marc Sluiter <[email protected]>
Signed-off-by: Marc Sluiter <[email protected]>
Signed-off-by: Marc Sluiter <[email protected]>
Signed-off-by: Marc Sluiter <[email protected]>
|
/test 4.15-openshift-e2e |
Signed-off-by: Marc Sluiter <[email protected]>
|
/test 4.15-openshift-e2e |
Signed-off-by: Marc Sluiter <[email protected]>
|
/test 4.15-openshift-e2e |
|
@slintes: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
closing in favour of #226 /close |
|
@slintes: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
WIP
testing peer check e2e