Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade versions #142

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Upgrade versions #142

merged 3 commits into from
Dec 7, 2023

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Sep 19, 2023 •
edited
Loading

Upgraded SNR Tools version.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mshitrit
Copy link
Member Author

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.11-ci-index-self-node-remediation-bundle
  • /test 4.11-images
  • /test 4.11-openshift-e2e
  • /test 4.11-test
  • /test 4.12-ci-index-self-node-remediation-bundle
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.12-test
  • /test 4.13-ci-index-self-node-remediation-bundle
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.13-test
  • /test 4.14-ci-index-self-node-remediation-bundle
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.14-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member Author

/test 4.12-openshift-e2e

@mshitrit
Copy link
Member Author

/test 4.12-openshift-e2e

@mshitrit mshitrit force-pushed the upgrade-versions branch 2 times, most recently from 28c48a4 to c6c8b49 Compare September 19, 2023 15:42
@mshitrit
Copy link
Member Author

/test 4.12-openshift-e2e

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clobrano, mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mshitrit
version update
8771081 
Signed-off-by: Michael Shitrit <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Dec 6, 2023
@mshitrit
Copy link
Member Author

mshitrit commented Dec 6, 2023

/test 4.12-openshift-e2e

@mshitrit mshitrit changed the title [WIP] Upgrade versions Upgrade versions Dec 6, 2023
razo7
razo7 reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@razo7 razo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on using Golang v1.21 for now, except that it looks lgtm.

Makefile Outdated Show resolved Hide resolved
@razo7
Copy link
Member

razo7 commented Dec 7, 2023

I forgot that whenever we update operator-sdk it is better to update scorecard as well in https://github.com/medik8s/self-node-remediation/blob/main/config/scorecard/patches/basic.config.yaml#L7 and olm.config.yaml, and run make bundle.

@mshitrit
update scorecard yamls as well
c7b8f50 
Signed-off-by: Michael Shitrit <[email protected]>
@mshitrit
Copy link
Member Author

mshitrit commented Dec 7, 2023

/test 4.12-openshift-e2e

@razo7
Copy link
Member

razo7 commented Dec 7, 2023

/lgtm

@razo7 razo7 marked this pull request as ready for review December 7, 2023 12:00
@openshift-ci openshift-ci bot requested review from razo7 and slintes December 7, 2023 12:00
@razo7
Copy link
Member

razo7 commented Dec 7, 2023

/retest

1 similar comment
@mshitrit
Copy link
Member Author

mshitrit commented Dec 7, 2023

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 7a1b271 into medik8s:main Dec 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clobrano clobrano clobrano approved these changes

@razo7 razo7 Awaiting requested review from razo7

@slintes slintes Awaiting requested review from slintes

Assignees

@clobrano clobrano

@razo7 razo7

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshitrit @razo7 @clobrano @openshift-merge-robot