Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config value of safe time to reboot was calculated wrongly #140

Conversation

mshitrit
Copy link
Member

@mshitrit mshitrit commented Sep 6, 2023

ECOPROJECT-1630
safeTimeToAssumeNodeRebootedSeconds doesn't impact actual time of node returning to health.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mshitrit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 6, 2023
@mshitrit
Copy link
Member Author

mshitrit commented Sep 6, 2023

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

@mshitrit: The following commands are available to trigger required jobs:

  • /test 4.11-ci-index-self-node-remediation-bundle
  • /test 4.11-images
  • /test 4.11-openshift-e2e
  • /test 4.11-test
  • /test 4.12-ci-index-self-node-remediation-bundle
  • /test 4.12-images
  • /test 4.12-openshift-e2e
  • /test 4.12-test
  • /test 4.13-ci-index-self-node-remediation-bundle
  • /test 4.13-images
  • /test 4.13-openshift-e2e
  • /test 4.13-test
  • /test 4.14-ci-index-self-node-remediation-bundle
  • /test 4.14-images
  • /test 4.14-openshift-e2e
  • /test 4.14-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mshitrit
Copy link
Member Author

mshitrit commented Sep 6, 2023

/test 4.12-openshift-e2e

1 similar comment
@mshitrit
Copy link
Member Author

mshitrit commented Sep 6, 2023

/test 4.12-openshift-e2e

main.go Show resolved Hide resolved
@clobrano
Copy link
Contributor

clobrano commented Sep 7, 2023

/lgtm
Giving others a chance to review as well, feel free to un-hold
/hold

@mshitrit
Copy link
Member Author

mshitrit commented Sep 7, 2023

/test 4.12-openshift-e2e

@clobrano
Copy link
Contributor

clobrano commented Sep 7, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 7, 2023
@razo7 razo7 marked this pull request as ready for review September 7, 2023 08:55
@openshift-ci openshift-ci bot requested review from razo7 and slintes September 7, 2023 08:55
@mshitrit
Copy link
Member Author

mshitrit commented Sep 7, 2023

/unhold

@mshitrit
Copy link
Member Author

mshitrit commented Sep 7, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 6b819a4 into medik8s:main Sep 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants